-
Notifications
You must be signed in to change notification settings - Fork 94
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Syncer/Reconciler Refactor #15
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 885
💛 - Coveralls |
patrick-ogrady
force-pushed
the
syncer-refactor
branch
from
May 6, 2020 23:17
da14952
to
7c5d199
Compare
patrick-ogrady
force-pushed
the
syncer-refactor
branch
2 times, most recently
from
May 7, 2020 16:01
344b410
to
f832824
Compare
patrick-ogrady
changed the title
[WIP] Syncer/Reconciler refactor
Syncer/Reconciler Refactor
May 7, 2020
patrick-ogrady
force-pushed
the
syncer-refactor
branch
from
May 7, 2020 16:12
f832824
to
1da24db
Compare
patrick-ogrady
requested review from
niallo,
annieke,
brockmiller,
etscrivner,
zquestz,
defnotpaul and
a team
May 7, 2020 16:33
zquestz
reviewed
May 7, 2020
zquestz
reviewed
May 7, 2020
zquestz
reviewed
May 7, 2020
patrick-ogrady
force-pushed
the
syncer-refactor
branch
2 times, most recently
from
May 7, 2020 23:19
2c68956
to
665e677
Compare
zquestz
approved these changes
May 8, 2020
patrick-ogrady
force-pushed
the
syncer-refactor
branch
from
May 8, 2020 14:46
665e677
to
6e13cf2
Compare
brockmiller
approved these changes
May 8, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problems
syncer
andreconciler
packages in their own applications, however, these packages were tightly coupled to the other packages inrosetta-cli
.reconciler
andsyncer
in thestateful_x
andstateless_x
implementations.check:complete
) and stateless syncer (check:quick
). Having 2 commands to check validity was extremely confusing for new users.Solutions
internal
dependencies fromsyncer
andreconciler
to prepare for a migration torosetta-sdk-go
. It is now possible to provide your own storage and communication implementation.syncer
andreconciler
to work regardless of whether starting fromgenesis
or some arbitrary height. This made the implementation much simpler and removed plenty of redundant code.check
command that determines how to prepare storage to sync from any index. If you start from genesis, it will perform a comprehensive check. If you start from an arbitrary height, limited checks will be run.Future PR
syncer
andreconciler
packages torosetta-sdk-go