Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes inability to turn off URL analytics #101

Merged
merged 1 commit into from
Dec 14, 2023
Merged

Fixes inability to turn off URL analytics #101

merged 1 commit into from
Dec 14, 2023

Conversation

colbyfayock
Copy link
Collaborator

Description

Updates the construct URL function to work properly when analytics is disabled.

Previous, passing the config.url.analytics as false would work, but not the analytics function option.

This normalizes behavior and makes sure it works as expected

Issue Ticket Number

Helps to address issue found: nuxt-modules/cloudinary#174

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Fix or improve the documentation
  • This change requires a documentation update

Checklist

  • I have followed the contributing guidelines of this project as mentioned in CONTRIBUTING.md
  • I have created an issue ticket for this PR
  • I have checked to ensure there aren't other open Pull Requests for the same update/change?
  • I have performed a self-review of my own code
  • I have run tests locally to ensure they all pass
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes needed to the documentation

@vercel Vercel
Copy link

vercel bot commented Dec 11, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
cloudinary-util ❌ Failed (Inspect) Dec 11, 2023 4:53pm

@colbyfayock colbyfayock mentioned this pull request Dec 11, 2023
Closed
@colbyfayock colbyfayock merged commit c6bd741 into main Dec 14, 2023
5 of 6 checks passed
@colbyfayock colbyfayock deleted the analytics-disable branch December 14, 2023 20:06
github-actions bot pushed a commit that referenced this pull request Dec 14, 2023
@semantic-release-bot
chore(release): 3.23.0 [skip ci]
a79e1e8 
# [@cloudinary-util/url-loader-v3.23.0](https://github.com/colbyfayock/cloudinary-util/compare/@cloudinary-util/url-loader-v3.22.0...@cloudinary-util/url-loader-v3.23.0) (2023-12-14)

### Features

* Fixes inability to turn off URL analytics  ([#101](#101)) ([c6bd741](c6bd741))
@github-actions GitHub Actions
Copy link

🎉 This PR is included in version @cloudinary-util/url-loader-v3.23.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@colbyfayock