Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

log4r-color merge? #61

Open
maxglassie opened this issue May 22, 2018 · 2 comments
Open

log4r-color merge? #61

maxglassie opened this issue May 22, 2018 · 2 comments

Comments

@maxglassie
Copy link

maxglassie commented May 22, 2018

Would it be possible to merge this repo, which enables colorized stdout, into the existing library? Is there a reason this hasn't been done?

I did not write the colorize extension, but I've been looking through the code and the changes seem reasonable to me. Admittedly, I don't know what else those changes might impact.

I also imagine you all have considered this before, so forgive me if that conversation to add colorized output has already occurred.

log4r-color

It uses colorize

@joshjhall
Copy link

joshjhall commented May 28, 2018

There's also a very simple PR that adds a new formatter option %L for colorizing the console. I'm no ruby expert by any stretch, but the changes seem quite low risk, and it doesn't add any dependency on colorize.

+1 for either approach really. I like a bit of color in my console :)

@maxglassie
Copy link
Author

I’m down for either solution and happy to help code it up. I’m using a blend of libraries right now and the monkey patching makes me ancy.

What’s the formatter PR you speak of @joshjhall

May I help with that?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants