Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Confusing wording in documentation https://ckbunker.com/policy.html#individual-rules #8

Closed
KISBITCOIN opened this issue Feb 3, 2021 · 2 comments

Comments

@KISBITCOIN
Copy link

KISBITCOIN commented Feb 3, 2021

Screen Shot 2021-02-03 at 11 17 36 AM

When an element of the rule is has no value, then the restriction does not apply. For example, if Destination Whitelist is empty, then the Coldcard will not consider the destination address when considering the rule.

If no rules are defined, then no PSBT will be signed. This can be useful for text message signing applications. On the other hand, an empty rule, allows any transaction to be signed, so be careful!

This reads to me as - if no rules are defined (empty parameter) then no PSBT will be signed, ie... all submitted PSBT's will be denied.

Maybe you should remove the

If no rules are defined, then no PSBT will be signed.

If empty==undefined, you should pick one word and use it throughout documentation.

My assessment of this section is : if all rules are empty then any PSBT submitted will be signed.

Please clarify so I can explain properly in Guide.

@doc-hex
Copy link
Contributor

doc-hex commented Feb 3, 2021

empty != undefined.

  • no rules => no PSBT signing
  • one empty rule => everything signed (no restrictions)
  • more empty rules => same as a single empty rule.

@KISBITCOIN
Copy link
Author

KISBITCOIN commented Feb 4, 2021 via email

@doc-hex doc-hex closed this as completed Feb 9, 2021
doc-hex added a commit that referenced this issue Feb 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants