Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor to use TonalJS for note value conversion #2

Closed
colinfwren opened this issue Dec 5, 2022 · 0 comments · Fixed by #3
Closed

Refactor to use TonalJS for note value conversion #2

colinfwren opened this issue Dec 5, 2022 · 0 comments · Fixed by #3
Assignees
@colinfwren

Comments

@colinfwren
Copy link
Owner

colinfwren commented Dec 5, 2022 •
edited
Loading

TonalJS has a lot of awesome helper functions that handle converting MIDI note values to different representations.
@colinfwren colinfwren self-assigned this Dec 5, 2022
@colinfwren colinfwren changed the title Refactor to use TonalJS for note value conversion and MIDI parsing Refactor to use TonalJS for note value conversion Dec 5, 2022
@colinfwren colinfwren linked a pull request Dec 5, 2022 that will close this issue
[REFACTOR] Use TonalJS instead of rolling own note logic #3
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@colinfwren colinfwren

Labels
None yet
Projects
midi-to-lsdj Features
Status: ✅ Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[REFACTOR] Use TonalJS instead of rolling own note logic colinfwren/midi-to-lsdj
1 participant
@colinfwren