Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hide uninstall profile #32

Closed
wants to merge 1 commit into from
Closed

Hide uninstall profile #32

wants to merge 1 commit into from

Conversation

wesleybl
Copy link
Member

No description provided.

@codecov-commenter
Copy link

codecov-commenter commented Apr 27, 2022

Codecov Report

Merging #32 (7192d2a) into master (127d9c5) will increase coverage by 0.87%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master      #32      +/-   ##
==========================================
+ Coverage   87.50%   88.37%   +0.87%     
==========================================
  Files           4        5       +1     
  Lines          80       86       +6     
==========================================
+ Hits           70       76       +6     
  Misses         10       10              
Impacted Files Coverage Δ
src/collective/recaptcha/setuphandlers.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 127d9c5...7192d2a. Read the comment docs.

Copy link
Member

@ale-rt ale-rt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@wesleybl
Copy link
Member Author

wesleybl commented May 2, 2022

@ale-rt I noticed that Plone 5.2 itself hides the uninstall profile of prefs_install_products_form. As the next release will be for Plone >= 5.2, this is not necessary. Thank you!

@wesleybl wesleybl closed this May 2, 2022
@wesleybl wesleybl deleted the hidde_uninstall branch May 2, 2022 15:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants