Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NOJIRA Replace glob call with Zend\Stdlib\Glob::glob #508

Merged
merged 1 commit into from
Jul 9, 2020
Merged

Conversation

kehh
Copy link
Contributor

@kehh kehh commented Jul 9, 2020

* Running on docker using an Alpine PHP image resulted in warnings and failed globbing.
* docker-library/php#719
@collectiveaccess collectiveaccess merged commit bb10a6d into collectiveaccess:develop Jul 9, 2020
@yelto
Copy link
Contributor

yelto commented Jul 19, 2020

Alpine sounds like an interesting target. The commit might be a little aggressive though, I am not sure what the plan is going forward with Zend/Laminas (maybe a full refresh?) but at the moment at least, providence/app/lib/Zend/Stdlib is not complete (no Glob in particular), so the build is broken..

@collectiveaccess
Copy link
Owner

@yelto Try doing a composer update on your install. This PR work fine for me, but of course you do need to have the libraries installed.

@yelto
Copy link
Contributor

yelto commented Jul 20, 2020

Oh, sorry it's been a while, used to build providence bare metal, I did not realize that composer was the canonical way as there is a semi-populated Zend/Stdlib/ in the code base. Can vagrant and editorconfig be relied upon as well? Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants