-
Notifications
You must be signed in to change notification settings - Fork 956
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix rubocop errors #826
Fix rubocop errors #826
Conversation
👍 for getting this merged in. |
@@ -13,3 +14,4 @@ Gem::Specification.new do |spec| | |||
spec.test_files = Dir.glob('spec/**/*') | |||
spec.version = '4.0.6' | |||
end | |||
# rubocop:enable SpaceAroundOperators |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think you need to re-enable after disabling
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Rubocop Readme https://github.com/bbatsov/rubocop has them being re-enabled, except for one-liners.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the disable comments are scoped by file, so re-enabling isn't needed in this case, because it will be enabled for other files anyway... but it doesn't hurt! 😅
Thanks for submitting this. Fixed in cc52c72. |
No description provided.