Skip to content

Commit

Permalink
Bump major version to be consistent with delayed_job version
Browse files Browse the repository at this point in the history
  • Loading branch information
@sferik
sferik committed Mar 2, 2013
1 parent fcb5d24 commit 2611574
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion delayed_job_active_record.gemspec
View file
Original file line number Diff line number Diff line change
Expand Up @@ -15,5 +15,5 @@ Gem::Specification.new do |spec|
spec.require_paths = ['lib']
spec.summary = 'ActiveRecord backend for DelayedJob'
spec.test_files = Dir.glob("spec/**/*")
spec.version = '0.4.2'
spec.version = '4.0.0.beta1'
end

4 comments on commit 2611574

@albus522
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are currently no breaking changes. Why are we diverging development into multiple branches? Isn't it enough to just list supported versions in the readme and gemspec?

@albus522
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, so I missed a couple of changes, however, I see no reason we couldn't maintain support for both AR versions in 1 gem. I'll put together a couple of pull requests, and we can discuss further.

@sferik
Copy link
Collaborator Author

@sferik sferik commented on 2611574 Apr 1, 2013

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There appear to be some changes to migrations between Rails 3 and Rails 4 (see #41 and #45). Will you be able to reconcile these changes in #47?

@sferik
Copy link
Collaborator Author

@sferik sferik commented on 2611574 Apr 1, 2013

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My thinking was to make the version number:

  1. 1.0, since the API is stable and people use it in production

  2. Consistent with the version of delayed_job that it depends on
  3. Consistent with the version of rails that it supports (this is more of a happy coincidence)

Please sign in to comment.