-
Notifications
You must be signed in to change notification settings - Fork 336
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WIP: Merge diverging development #47
Conversation
Need to work out the exclusion list for incompatible combinations
Inspired by @laserlemon
I am in complete agreement that we should not break compatibility with earlier Active Record versions unless and until we must (i.e. it's impossible to be compatible with both using the same code). I apologize for breaking this and would like to restore it. Thanks for your work on this. |
I am currently working on getting the test suite green on Travis. Currently having some issues with jruby on Travis. Everything passes locally, but there is something odd with the load path order on Travis. Technically we are safe to merge now, but I would really like to sort out Travis first. |
Once you’re done tweaking the Travis settings and tests are green, please squash the tweak commits. Also, please take a look at this comment: 2611574#commitcomment-2920179 |
This is kind of a dual purpose pull request.
First: I would like to keep all development in 1 branch until we really need the code to drastically change based on AR versions. I was able to keep things compatible with 1 parse time AR version check.
Second: I have added AR versions to the build matrix to yell at us when we break compatibility. I am pretty sure the matrix is going to have a few incompatible combinations that I still need to sort out, but this is a start. Also currently, or prior to #46, 3.0 and 3.1 compatibility is/was broken. If we decide diverging development is where we need to go #46 will need to also be ported to 0-4-stable.
@sferik thoughts/comments?