Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Flatbuffers update #132

Closed
2 tasks done
collinsmith opened this issue Nov 30, 2020 · 2 comments
Closed
2 tasks done

Flatbuffers update #132

collinsmith opened this issue Nov 30, 2020 · 2 comments
Labels
enhancement help wanted

Comments

@collinsmith
Copy link
Owner

collinsmith commented Nov 30, 2020 •
edited

  • flatc should be included within the repository under /flatbuffers/ as it's closely linked with dependency version
  • Upgrading to 1.12.0 requires generating new sources due to API change

Note: I looked into adding flatbuffers as a build task, but this isn't possible due to not having a readily available binary for linux builds. The gradle task will be there for those who feel like compiling.

Closes #44
@collinsmith collinsmith mentioned this issue Nov 30, 2020
Closed
collinsmith added a commit that referenced this issue Dec 1, 2020
@collinsmith
Refined flatbuffers dependency implementation (see #132)
6e44b4d 
Included flatc.exe within repository (v1.11.0 binary)
Added check within :core:createFlatBuffers task for Windows OS family
Added flatbuffersVersion variable within gradle.properties to 1.11.0
Changed many fields to variables and implemented flatbuffers closure
@collinsmith
Copy link
Owner Author

flatc is now included within the repository and the flatbuffers gradle plugin will use 1.11.0 (it automatically includes a default version which was 1.10.0, but I don't think it was being used). I also added a check for :core:createFlatBuffers task to make sure the build is taking place on Windows.

Long term -- I think flatbuffers may be moved outside of src/main/java into src/main/flatbuffers to simplify some of the implementation details in these gradle tasks. I also want to change the tasks to make :core:build depend on :core:createFlatBuffers, but also only enable the task if building on windows -- or maybe throw a warning otherwise if the task is not UP-TO-DATE (don't need to run the task if no changes, but changes can only be made on Windows since flatc is a Windows executable).

collinsmith added a commit that referenced this issue Dec 1, 2020
@collinsmith
Updated flatbuffers version to 1.12.0 (see #132)
080ac48
@collinsmith
Copy link
Owner Author

This was resolved in 080ac48 as far as I've double checked.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement help wanted
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@collinsmith