New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix bug in UpdateFromDict #231

Merged

sarlinpe merged 2 commits into master from sarlinpe/updatefromdict-fix

Jan 11, 2024

Collaborator

sarlinpe commented Jan 11, 2024 •

edited

Loading

Fix the bug mentioned in Expose a bundle_adjustment function #146:

solver_options = pycolmap.CeresSolverOptions(max_num_iterations=256)
ba_opts = pycolmap.BundleAdjustmentOptions({"solver_options": solver_options})  # error

Explicitly raise an error if a dict key is not a string
Overall cleanup

sarlinpe added 2 commits

January 11, 2024 16:12


          Improve UpdateFromDict

4d7cea1


          Cleanup other functions

711db0d

sarlinpe requested review from mihaidusmanu and Phil26AT

January 11, 2024 15:27

Phil26AT approved these changes

View reviewed changes

sarlinpe merged commit 8635df8 into master

6 checks passed

sarlinpe deleted the sarlinpe/updatefromdict-fix branch

January 11, 2024 16:24

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet