remoteRoomCall: force JSON serialization on local (same-process) calls

colyseus · Oct 17, 2022 · 151668b · 151668b · WeroldFrannie · Mar 22, 2023
1 parent ca7c61f
commit 151668b
Show file tree

Hide file tree

Showing 2 changed files with 22 additions and 1 deletion.
diff --git a/bundles/colyseus/test/MatchMakerTest.ts b/bundles/colyseus/test/MatchMakerTest.ts
@@ -450,6 +450,27 @@ describe("MatchMaker", () => {
         assert.strictEqual(true, rooms[2].locked);
       });
 
+      it("remote room call should always serialize as JSON", async () => {
+        matchMaker.defineRoomType('remoteroomcall', class _ extends Room {
+          methodName(arg1, arg2) {
+            return [arg1, arg2];
+          }
+        });
+
+        class CustomClass {
+          attr = 1;
+        }
+
+        const reservedSeat = await matchMaker.joinOrCreate("remoteroomcall");
+        const result = await matchMaker.remoteRoomCall(reservedSeat.room.roomId, "methodName", [new CustomClass(), new CustomClass()]);
+
+        assert.ok(!(result[0] instanceof CustomClass));
+        assert.ok(!(result[1] instanceof CustomClass));
+
+        assert.strictEqual(result[0].attr, 1);
+        assert.strictEqual(result[1].attr, 1);
+      });
+
       describe("concurrency", async () => {
         it("should create 50 rooms", async () => {
           const numConnections = 100;

diff --git a/packages/core/src/MatchMaker.ts b/packages/core/src/MatchMaker.ts
@@ -184,7 +184,7 @@ export async function remoteRoomCall<R= any>(
   } else {
     return (!args && typeof (room[method]) !== 'function')
         ? room[method]
-        : (await room[method].apply(room, args));
+        : (await room[method].apply(room, args && args.map((arg) => JSON.parse(JSON.stringify(arg)))));
   }
 }