Split up Main.scala into Main.scala/MainRunner.scala/AmmoniteMain.scala #1229
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexarchambault
approved these changes
Nov 29, 2021
lefou
reviewed
Dec 10, 2021
| * The command-line entry point, which does all the argument parsing before | ||
| * delegating to [[Main.run]] | ||
| */ | ||
| def main(args0: Array[String]): Unit = { |
There was a problem hiding this comment.
Is it possible, to keep a @deprecated forwarder to the moved main here?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should help make things easier to find.
The dependency order is
AmmoniteMain.scaladepends onMainRunner.scaladepends onMain.scalaThe new main method is in
ammonite.AmmoniteMain. This was chosen to help improve the UX of tools likejpswhich only list the classname and not the package path as part of its output. Previously it would just show a mysteriousMainJVM process running, with this change it'll showAmmoniteMainwhich is a lot more useful.A few minor helper functions needed to be moved around to preserve acyclicity of the three files, I moved them all to
ammonite.util