fix: make sure runEither isn't calling itself
#107
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It looks like this was overlooked and the overloaded `runEither` is just constantly calling itself resulting in a stack overflow. This changes it to call the newly created `runEither` with the `nameMapper` which I believe is the intended flow. fixes com-lihaoyi#106
ckipp01
force-pushed
the
recursionGoneWrong
branch
from
fa07c10
to
a8653fd
Compare
|
Thanks @ckipp01 ! Will cut a new release |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It looks like this was overlooked and the overloaded
runEitheris just constantly calling itself resulting in a stack overflow. This changes it to call the newly createdrunEitherwith thenameMapperwhich I believe is the intended flow.fixes #106