Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ivyDepsTree does not show transitive dependencies #226

Closed
francisdb opened this issue Mar 13, 2018 · 5 comments
Closed

ivyDepsTree does not show transitive dependencies #226

francisdb opened this issue Mar 13, 2018 · 5 comments
Labels
solved The issue was fixed/resolved
Milestone

Comments

@francisdb
Copy link
Contributor

loggingLogentries.ivyDepsTree()()
[4/4] loggingLogentries.ivyDepsTree
└─ com.logentries:logentries-appender:1.1.38

but this module also depends on akka through transitive moduleDeps ivyDeps

On a side note
logentries-appender also has transitive dependencies, but these seem to be marked as optional (http://search.maven.org/#artifactdetails|com.logentries|logentries-appender|1.1.38|pom)

@lihaoyi
Copy link
Member

lihaoyi commented Mar 14, 2018

@francisdb you're probably going to have to dig through the code using ivy/coursier, debug this yourself, and explain to us the solution 😛 I know ivy/coursier as little as anyone else... I don't even know what an optional dependency means, or if this is a problem or not

@francisdb
Copy link
Contributor Author

This is probably related to #211

@francisdb
Copy link
Contributor Author

Not fixed by #211
mill show loggingLogentries.compileClasspath contains more than the dependencyTree

@lihaoyi
Copy link
Member

lihaoyi commented Apr 7, 2018

Should be fixed by b9e9b68

I can't reproduce it because there is not enough information here to repro; if it's still happening send a PR with a test case and I'll be able to fix it properly

@lihaoyi lihaoyi closed this as completed Apr 7, 2018
@francisdb
Copy link
Contributor Author

Please re-open, here is the requested reproducer:

Calling ivyDepsTree on both modules should give the same results but on bar the tree is empty

import mill._
import mill.scalalib._
object foo extends ScalaModule {
  def scalaVersion = "2.12.4"
  def ivyDeps = Agg(
    ivy"com.typesafe.play::play-json:2.6.8"
  )
}
object bar extends ScalaModule {
  def moduleDeps = Seq(foo)
  def scalaVersion = "2.12.4"
}
➜  test ~/Downloads/0.1.7-77-44ed2e bar.ivyDepsTree
[4/4] bar.ivyDepsTree
➜  test ~/Downloads/0.1.7-77-44ed2e foo.ivyDepsTree
[4/4] foo.ivyDepsTree
└─ com.typesafe.play:play-json_2.12:2.6.8
   ├─ com.fasterxml.jackson.core:jackson-annotations:2.8.9
   ├─ com.fasterxml.jackson.core:jackson-core:2.8.9
   ├─ com.fasterxml.jackson.core:jackson-databind:2.8.9
   │  ├─ com.fasterxml.jackson.core:jackson-annotations:2.8.0 -> 2.8.9
   │  └─ com.fasterxml.jackson.core:jackson-core:2.8.9
   ├─ com.fasterxml.jackson.datatype:jackson-datatype-jdk8:2.8.9
   │  ├─ com.fasterxml.jackson.core:jackson-core:2.8.9
   │  └─ com.fasterxml.jackson.core:jackson-databind:2.8.9
   │     ├─ com.fasterxml.jackson.core:jackson-annotations:2.8.0 -> 2.8.9
   │     └─ com.fasterxml.jackson.core:jackson-core:2.8.9
   ├─ com.fasterxml.jackson.datatype:jackson-datatype-jsr310:2.8.9
   │  ├─ com.fasterxml.jackson.core:jackson-annotations:2.8.0 -> 2.8.9
   │  ├─ com.fasterxml.jackson.core:jackson-core:2.8.9
   │  └─ com.fasterxml.jackson.core:jackson-databind:2.8.9
   │     ├─ com.fasterxml.jackson.core:jackson-annotations:2.8.0 -> 2.8.9
   │     └─ com.fasterxml.jackson.core:jackson-core:2.8.9
   ├─ com.typesafe.play:play-functional_2.12:2.6.8
   │  └─ org.scala-lang:scala-library:2.12.2
   ├─ joda-time:joda-time:2.9.9
   ├─ org.scala-lang:scala-library:2.12.2
   ├─ org.scala-lang:scala-reflect:2.12.2
   │  └─ org.scala-lang:scala-library:2.12.2
   └─ org.typelevel:macro-compat_2.12:1.1.1
      └─ org.scala-lang:scala-library:2.12.0 -> 2.12.2

the compileClasspath for bar does contain the dependencies

➜  test ~/Downloads/0.1.7-77-44ed2e show bar.compileClasspath
[1/1] show
[28/36] bar.resources
[
    {
        "path": "/Users/francisdb/workspace/test/foo/resources",
        "quick": false,
        "sig": -914035544
    },
    {
        "path": "/Users/francisdb/workspace/test/out/foo/compile/dest/classes",
        "quick": false,
        "sig": -914035544
    },
    {
        "path": "/Users/francisdb/workspace/test/bar/resources",
        "quick": false,
        "sig": -914035544
    },
    {
        "path": "/Users/francisdb/.coursier/cache/v1/https/repo1.maven.org/maven2/org/scala-lang/scala-library/2.12.4/scala-library-2.12.4.jar",
        "quick": true,
        "sig": 1584311055
    },
    {
        "path": "/Users/francisdb/.coursier/cache/v1/https/repo1.maven.org/maven2/org/scala-lang/scala-reflect/2.12.2/scala-reflect-2.12.2.jar",
        "quick": true,
        "sig": 1460944155
    },
    {
        "path": "/Users/francisdb/.coursier/cache/v1/https/repo1.maven.org/maven2/com/typesafe/play/play-json_2.12/2.6.8/play-json_2.12-2.6.8.jar",
        "quick": true,
        "sig": -1915147611
    },
...

@lihaoyi lihaoyi reopened this Apr 9, 2018
@rockjam rockjam closed this as completed in a3d8d4e Apr 9, 2018
@lefou lefou modified the milestones: after 0.3.6, 0.2.0 May 2, 2019
@lefou lefou added the solved The issue was fixed/resolved label Jul 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
solved The issue was fixed/resolved
Projects
None yet
Development

No branches or pull requests

3 participants