Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unify MillBuildModule with MillBuildRootModule #2414

Closed
lihaoyi opened this issue Apr 4, 2023 · 1 comment · Fixed by #2415
Closed

Unify MillBuildModule with MillBuildRootModule #2414

lihaoyi opened this issue Apr 4, 2023 · 1 comment · Fixed by #2415
Milestone
0.11.0-M9

Comments

@lihaoyi
Copy link
Member

lihaoyi commented Apr 4, 2023

MillBuildModule is basically a lightweight partial implementation of MillBuildRootModule. Now that we have MillBuildRootModule, we should use it
@lihaoyi lihaoyi mentioned this issue Apr 4, 2023
Merged
@lefou lefou linked a pull request Apr 4, 2023 that will close this issue
Re-use MillBuildRootModule for BSP #2415
Merged
@lefou
Copy link
Member

lefou commented Apr 24, 2023

Also, expose the mill-build to be used by mill. Maybe we can expose it as an external module. Or we could invent some cli arg to enable the meta-build.

@lefou lefou mentioned this issue Apr 25, 2023
Closed
@lefou lefou mentioned this issue May 2, 2023
Open
@lefou lefou added this to the 0.11.0-M9 milestone May 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.11.0-M9
Development

Successfully merging a pull request may close this issue.

Re-use MillBuildRootModule for BSP lihaoyi/mill-1
2 participants
@lihaoyi @lefou