Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Extract Target-selection logic out of Main and write some unit tests #4

Closed
lihaoyi opened this issue Nov 21, 2017 · 1 comment
Closed

Extract Target-selection logic out of Main and write some unit tests #4

lihaoyi opened this issue Nov 21, 2017 · 1 comment
Assignees
@andreaTP

Comments

@lihaoyi
Copy link
Member

lihaoyi commented Nov 21, 2017 •
edited

https://github.com/lihaoyi/mill/blob/1382e27191e662da2be0ec904c6266c7f21bc68d/core/src/main/scala/mill/Main.scala#L25-L112
This is currently a bit messy, but the logic is complex enough (with enough error conditions) that it deserves some proper testing.

Cross-building with mill Core.cross[a].printIt works, but mill Core.cross[doesntExist].printIt fails with an ugly exception, and it would be great if we could tighten up error handling and lock it down with unit tests as part of this effort
@lihaoyi
Copy link
Member Author

lihaoyi commented Nov 25, 2017

This happened

@lihaoyi lihaoyi closed this as completed Nov 25, 2017
lefou pushed a commit that referenced this issue Oct 16, 2019
@samvel1024
Merge pull request #4 from sequencer/bsp_patch
90d1265 
bug fix for system vended mill, no `MILL_CLASSPATH` avalible.
@lihaoyi lihaoyi mentioned this issue Mar 27, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@andreaTP andreaTP

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@lihaoyi @andreaTP