Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cannot select PGP key when signing files #529

Closed
lxohi opened this issue Jan 21, 2019 · 4 comments
Closed

Cannot select PGP key when signing files #529

lxohi opened this issue Jan 21, 2019 · 4 comments
Labels
solved The issue was fixed/resolved
Milestone

Comments

@lxohi
Copy link
Contributor

lxohi commented Jan 21, 2019

Hi,

I'm trying to publish my project to Maven Central using mill.

Setting up is quite fast & easy. But then I discovered that I cannot select the key used in PGP signing meanwhile there are multiple key pairs in my local machine.

I think maybe add a protected Option[String] member to PublishModule that specifies the key name and pass it all the way to here and then use it as the -u param of the gpg command will solve this issue.

What do you think about this change? If it's good, may I create a PR for this?

@lxohi lxohi changed the title Cannot select PGP key when sining files Cannot select PGP key when signing files Jan 21, 2019
@lihaoyi
Copy link
Member

lihaoyi commented Jan 21, 2019

sure

@lihaoyi
Copy link
Member

lihaoyi commented Jan 21, 2019

@lxohi I would prefer just passing in the key name as a flag to PublishModule.publishAll

@lxohi
Copy link
Contributor Author

lxohi commented Jan 21, 2019

OK. I'll send a PR later that passing the key name as a flag.

@lxohi
Copy link
Contributor Author

lxohi commented Jan 22, 2019

Closed due to #530 was already merged.

@lxohi lxohi closed this as completed Jan 22, 2019
@lefou lefou added this to the after 0.3.6 milestone Apr 18, 2019
@lefou lefou added the solved The issue was fixed/resolved label Jul 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
solved The issue was fixed/resolved
Projects
None yet
Development

No branches or pull requests

3 participants