Fetch more tooling deps in prepareOffine
#2294
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`ScalaJSModule` and `ScalaNativeModule` did not fetched their worker and tooling classpaths previously.
lolgab
reviewed
Jan 30, 2023
| @@ -235,6 +236,17 @@ trait ScalaJSModule extends scalalib.ScalaModule { outer => | |||
| /** Name patterns for output. */ | |||
| def scalaJSOutputPatterns: Target[OutputPatterns] = T { OutputPatterns.Defaults } | |||
|
|
|||
| override def prepareOffline(all: Flag): Command[Unit] = { | |||
| val tasks = | |||
| if (all.value) Seq(scalaJSToolsClasspath) | |||
There was a problem hiding this comment.
scalaJSToolsClasspath are not very big and necessary to do anything useful with ScalaJS (except plain compilation), so maybe they could be downloaded even without requiring the all flag.
What do you think?
There was a problem hiding this comment.
Yeah, makes sense. But with the same argument, we should always fetch Zinc dependencies in ScalaModule. Current scaladoc says:
/** @param all If `true` , fetches also sources, Ammonite and compiler dependencies. */There was a problem hiding this comment.
Then it agrees with current semantics 👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ScalaJSModuleandScalaNativeModuledid not fetched their worker and tooling classpaths previously.