Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed inner Tests traits to avoid no longer supported shadowing #2558

Merged
merged 10 commits into from
May 30, 2023

Conversation

lefou
Copy link
Member

@lefou lefou commented May 27, 2023

Replaced all usage site with the respective named inner test traits.

lefou and others added 9 commits May 30, 2023 07:46
.
# Conflicts:
#	example/scalabuilds/10-scala-realistic/build.sc
#	example/scalabuilds/5-test-suite/build.sc
#	example/scalabuilds/8-sbt-compat-modules/build.sc
#	example/web/1-todo-webapp/build.sc
#	example/web/2-webapp-cache-busting/build.sc
#	example/web/4-webapp-scalajs/build.sc
#	example/web/5-webapp-scalajs-shared/build.sc
#	example/web/6-cross-version-platform-publishing/build.sc
#	example/web/7-cross-platform-version-publishing/build.sc
#	integration/thirdparty/ammonite/repo/build.sc
#	integration/thirdparty/caffeine/repo/build.sc
#	integration/thirdparty/jawn/repo/build.sc
#	integration/thirdparty/upickle/repo/build.sc
@lefou lefou marked this pull request as ready for review May 30, 2023 07:16
@lefou lefou added the compat-breaker This PR is good to merge, but breaks compatibility and needs to wait till we prepare a major release label May 30, 2023
@lefou lefou requested a review from lihaoyi May 30, 2023 07:17
@lihaoyi lihaoyi merged commit 1a43818 into main May 30, 2023
38 of 39 checks passed
@lihaoyi lihaoyi deleted the remove-tests-traits branch May 30, 2023 14:38
@lefou lefou added this to the 0.11.0-M11 milestone May 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
compat-breaker This PR is good to merge, but breaks compatibility and needs to wait till we prepare a major release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants