Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add test for buildinfo with ScalaJS without special settings #2577

Merged
merged 2 commits into from
Aug 2, 2023
Merged

Add test for buildinfo with ScalaJS without special settings #2577

merged 2 commits into from
Aug 2, 2023

Conversation

lolgab
Copy link
Member

@lolgab lolgab commented Jun 7, 2023

No description provided.

@lolgab lolgab force-pushed the add-test-scalajs-buildinfo branch 3 times, most recently from 720dcd6 to 9e5b9fc Compare June 7, 2023 08:02
@lolgab lolgab marked this pull request as ready for review June 7, 2023 11:13
lihaoyi
lihaoyi approved these changes Jun 27, 2023
View reviewed changes
Copy link
Member

@lihaoyi lihaoyi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. I wonder why MIMA is failing? Maybe the PR just needs to be rebased on top of latest main?

@lolgab lolgab force-pushed the add-test-scalajs-buildinfo branch from 9e5b9fc to d70d114 Compare June 27, 2023 09:29
@lolgab
Copy link
Member Author

lolgab commented Jun 27, 2023

Looks good to me. I wonder why MIMA is failing? Maybe the PR just needs to be rebased on top of latest main?

Might be. I just rebased it from the Github UI.

lefou
lefou approved these changes Aug 2, 2023
View reviewed changes
Copy link
Member

@lefou lefou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@lefou lefou merged commit ddf0ad7 into com-lihaoyi:main Aug 2, 2023
37 checks passed
@lefou lefou added this to the 0.11.2 milestone Aug 2, 2023
@lolgab lolgab deleted the add-test-scalajs-buildinfo branch August 3, 2023 09:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lihaoyi lihaoyi lihaoyi approved these changes

@lefou lefou lefou approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.11.2
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@lolgab @lihaoyi @lefou