-
-
Notifications
You must be signed in to change notification settings - Fork 300
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make empty selector message more helpful #2610
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think showing a typical --help
text without request isn't an expected user experience. If there is an issue, we should tell it the user. There is a large gap between some usage hint and an error message with details.
While reviewing this PR, I recognized that we left some traces of --repl suport in the code base. I opened #2611 to fix that. |
Okay yeah, I guess an error message would be better than just usage instructions. Does |
I think so.
How about "Target selector must not be empty ..." |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
Regarding #2601. Currently, if no arguments are given to mill, it says
Selector cannot be empty
. It's not immediately clear what that's supposed to mean, so I figured it might be more helpful to print the help message instead in that case (some other tools do that). In addition to this, I modified the empty selector message to saySelector cannot be empty. Try `mill resolve _` to see what's available.
(the empty selector message still shows up if you do./mill --repl
).