Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup leftover --repl flag handling, fail when --repl is given #2611

Merged
merged 5 commits into from
Jun 15, 2023
Merged

Conversation

lefou
Copy link
Member

@lefou lefou commented Jun 15, 2023

In Mill 0.11.0-M8 we change Mill internals to no longer use Ammonite. Since then, we no longer support the --repl mode, but forgot to cleanup the CLI configuration.

@lefou
Copy link
Member Author

lefou commented Jun 15, 2023

@lihaoyi We probably also want to remove the --predef and --no-default-predef options?

@lefou lefou requested a review from lihaoyi June 15, 2023 06:08
Copy link
Member

@lihaoyi lihaoyi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah --predef and --no-default-predef are both irrelevant now

@lefou lefou merged commit 4b2fc0d into main Jun 15, 2023
37 checks passed
@lefou lefou deleted the clean branch June 15, 2023 14:31
@lefou lefou added this to the 0.11.1 milestone Jun 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants