Define reasonable platformSuffix in MillBuildPlatformModule

[lefou]

It's a typical use case to add plugin dependencies to a meta-build. To make this more convenient, we set the platformSuffix to _mill<binary-platform>.

• Fix MillBuildRootModule should preset the platformSuffix to _mill0.11 #2634

[lihaoyi]

This looks good to me. If we're relying on platformSuffix, should we also remove the special-case logic in

mill/runner/src/mill/runner/MillIvy.scala

Lines 10 to 16 in 8e6684f

	signature.split("[:]") match {
	case Array(org, "", pname, "", version)
	if org.length > 0 && pname.length > 0 && version.length > 0 =>
	s"${org}::${pname}_mill$$MILL_BIN_PLATFORM:${version}"
	case Array(org, "", "", pname, "", version)
	if org.length > 0 && pname.length > 0 && version.length > 0 =>
	s"${org}:::${pname}_mill$$MILL_BIN_PLATFORM:${version}"

that duplicates the handling of the second ::?

[lefou]

This looks good to me. If we're relying on platformSuffix, should we also remove the special-case logic in

mill/runner/src/mill/runner/MillIvy.scala

Lines 10 to 16 in 8e6684f

	signature.split("[:]") match {
	case Array(org, "", pname, "", version)
	if org.length > 0 && pname.length > 0 && version.length > 0 =>
	s"${org}::${pname}_mill$$MILL_BIN_PLATFORM:${version}"
	case Array(org, "", "", pname, "", version)
	if org.length > 0 && pname.length > 0 && version.length > 0 =>
	s"${org}:::${pname}_mill$$MILL_BIN_PLATFORM:${version}"

that duplicates the handling of the second ::?

I cleaned that up. We still need the pre-processor to handle special place holders and the empty version.