Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support Play Framework 3.0 and 2.9 #2772

Merged
merged 20 commits into from
Nov 7, 2023
Merged

Support Play Framework 3.0 and 2.9 #2772

merged 20 commits into from
Nov 7, 2023

Conversation

lolgab
Copy link
Member

@lolgab lolgab commented Sep 20, 2023 •
edited by lefou

  • Update Play 2.8 to 2.8.20
  • Add default twirlVersion for play based on playVersion
  • Add default twirlScalaVersion based on twirlVersion

Pull request: #2772

@lolgab
Support Play Framework 2.9
f126aba 
Update Play 2.8 to 2.8.20
@lefou
Copy link
Member

lefou commented Sep 20, 2023

Nice! Does this PR supersedes #2517? A test using Scala 3, which is supported since Play 2.9, would be nice, but if you don't have the bandwidth to add it, we can add it later.

@lolgab lolgab changed the title Support Play Framework 2.9 Support Play Framework 3.0 and 2.9 Nov 7, 2023
@lolgab lolgab marked this pull request as ready for review November 7, 2023 11:42
@lolgab lolgab requested review from lefou and lihaoyi November 7, 2023 12:03
@lefou lefou mentioned this pull request Nov 7, 2023
Closed
lefou
lefou approved these changes Nov 7, 2023
View reviewed changes
Copy link
Member

@lefou lefou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Thank you!

@lolgab lolgab merged commit d7859ca into com-lihaoyi:main Nov 7, 2023
37 checks passed
@lolgab lolgab deleted the play-2.9 branch November 7, 2023 14:01
@lefou lefou added this to the 0.11.6 milestone Nov 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lefou lefou lefou approved these changes

@lihaoyi lihaoyi Awaiting requested review from lihaoyi

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.11.6
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@lolgab @lefou