Allow publishing bridge for a single version #2822
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lolgab
force-pushed
the
allow-single-bridge-publishing
branch
from
ca092ad
to
a4e2b1b
Compare
lefou
reviewed
Oct 5, 2023
build.sc
Outdated
| val compilerBridgeScalaVersions = interp.watchValue(sys.env.get("MILL_COMPILER_BRIDGE_VERSIONS")) match { | ||
| case None => Seq.empty[String] | ||
| case Some("all") => bridgeScalaVersions | ||
| case Some(versions) => versions.split(',').toSeq |
There was a problem hiding this comment.
I'd add a .map(_.trim), just to be sure.
lefou
approved these changes
Oct 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Releasing a new version of the bridge just for adding a Scala version is wasteful.
We can publish the bridge just for the new version (in our case
2.13.12) without tagging a0.0.2.This PR adds a
bridge_versionsinput to theworkflow_dispatchwhich can beallfor the current behavior or a comma separated list of Scala versions. This way we can release the current bridge for Scala2.13.12and then add2.13.12to the list of supported bridges in a later PR.