Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Microsecond precision in chrome profile #2827

Merged
merged 1 commit into from
Oct 5, 2023

Conversation

lolgab
Copy link
Member

@lolgab lolgab commented Oct 5, 2023

Chrome profiles support microsecond precision, so we can use System.nanoTime instead of System.currentTimeMillis to have better profiles

@lolgab lolgab marked this pull request as ready for review October 5, 2023 15:58
@lolgab lolgab requested review from lihaoyi and lefou October 5, 2023 16:16
Copy link
Member

@lefou lefou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

API-wise, I'd rather keep the start/end params in the helper functions and avoid the need to calculate the duration on the client side, but it looks like you are convinced we can make Mill twice as fast. haha.

@lolgab
Copy link
Member Author

lolgab commented Oct 5, 2023

@lefou You got me :-D
Since they are private functions I'd go for the micro-optimized way of calculating it only once, but if you prefer as before I can use endTime. As you prefer :)

Copy link
Member

@lefou lefou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@lefou
Copy link
Member

lefou commented Oct 5, 2023

@lefou You got me :-D Since they are private functions I'd go for the micro-optimized way of calculating it only once, but if you prefer as before I can use endTime. As you prefer :)

I'm eager to analyze the benchmarks. 😜

@lolgab lolgab merged commit e703b7a into com-lihaoyi:main Oct 5, 2023
37 checks passed
@lolgab lolgab deleted the profile-microseconds branch October 5, 2023 23:11
@lolgab lolgab added this to the 0.11.6 milestone Oct 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants