Fix discovery of targets whose names get mangled due to their pseudo-private nature #2883
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lefou
added a commit
that referenced
this pull request
Nov 19, 2023
We now report the target name in case we weren't able to detect it's declaring parent class. Tested manually with a Mill version before the merge of #2883. ```scala // /tmp/mill-2844/build.sc import mill._ object mod extends Module { object foo extends Module { def bar = T { baz() } } private def baz = T { "baz" } } ``` ``` > mill -i dev.run /tmp/mill-2844 -i mod.foo.bar [1691/1691] dev.run [info] compiling 1 Scala source to /tmp/mill-2844/out/mill-build/compile.dest/classes ... [info] done compiling Could not detect the parent class of target mod.baz. Please report this at https://github.com/com-lihaoyi/mill/issues/new/choose. As a workaround, you can run Mill with `--disable-callgraph-invalidation` option. ``` Pull request: #2885
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2844
Adds an integration test to cover this edge case, a few other permutations of it that I could come up with, and other
private-related behavior. I'm not sure if I managed to catch all different ways these methods can be mangled, but if I missed any we can discover/add them later. This new test fails if I remove any part of the code change inGroupEvaluator.scalaI'm actually not sure if this should be an integration test or a unit test.
defs are wrapped in nestedobjects/traits/classes, which is something that unit tests do not do realistically.privatetarget from the command, since it will simply not compile (beingprivateand all), and AFAICT this is somewhere we're missing coverage (unrelated to this specific failure mode)So I went with integration test.
Pull request: #2883