Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add 'jvmOptions' to docker contrib configuration #3079

Merged
merged 3 commits into from
Mar 11, 2024
Merged

Add 'jvmOptions' to docker contrib configuration #3079

merged 3 commits into from
Mar 11, 2024

Conversation

megri
Copy link
Contributor

@megri megri commented Mar 11, 2024

No description provided.

lefou
lefou reviewed Mar 11, 2024
View reviewed changes
Copy link
Member

@lefou lefou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! Please also update the documentation. It's under contrib/docker/readme.adoc.

@megri
Copy link
Contributor Author

megri commented Mar 11, 2024

Thank you! Please also update the documentation. It's under contrib/docker/readme.adoc.

Done! Let me know if it's clear enough.

lefou
lefou approved these changes Mar 11, 2024
View reviewed changes
Copy link
Member

@lefou lefou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@lefou lefou changed the title Add 'jvmArgs' option to docker contrib configuration. Add 'jvmOptions' to docker contrib configuration Mar 11, 2024
@lefou lefou merged commit b233801 into com-lihaoyi:main Mar 11, 2024
38 checks passed
@lefou lefou added this to the 0.11.8 milestone Mar 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lefou lefou lefou approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.11.8
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@megri @lefou