-
-
Notifications
You must be signed in to change notification settings - Fork 310
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix AssemblyTests on Windows #3288
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@sake92 Thank you for the fix! Can you please format it and also bump the Mill version to 0.11.9
so we see it succeeds? Thank you
@lefou where do I bump the mill version, in |
Yes. |
Seems like scalalib tests are green now. |
Looks like there are some new unrelated test failures for Windows now. Since we now know, the assembly tests are fixed by this PR, we could remove the Mill bump, and merge this PR (and close the bounty, I guess). |
Co-authored-by: Tobias Roeser <le.petit.fou@web.de>
I guess it would be fair to make the CI green first, before closing the bounty. 😁 |
Yeah. That was the idea by not bumping Mill to cause unrelated issues. |
@lefou we can merge this one? |
Depends on #3285
Windows has an env var called
PATHEXT
whish is usually something like this:.COM;.EXE;.BAT;.CMD;.VBS;.VBE;.JS;.JSE;.WSF;.WSH;.MSC
Basically a list of extensions considered as executable.
So the file in Mill's case needs to be a
.bat
file.Issue analyzed and fixed by @sake92
Fix #3283