Ability to pass GPG arguments to publish

[joan38]

Not sure if we are ok to break the interface here. If not I can probably add back gpgPassphrase and gpgKeyName with a @deprecated and wire that to gpgArgs.

[lefou]

I like this more than #753.

Now, that you've touched these method signatures, can you please also add scaladoc to the method and it's parameters?

[lefou]

Wondering, if we should move these defaults into the default param to gpgArgs and document it's meaning. It's not a change request, just a thought. WDYT?

[joan38]

I was thinking the same but then people need to be aware that if there specify the --gpgArgs they need to provide these too to keep them.

[lefou]

We could add a hint in the scaladoc, too. But having these hard-coded args screams for future maintenance work, as seen in the past (#345, #530, #753). We could also rename the parameter to alternativeGpgArgs or overrideGpgArgs to indicate the fact that it replaced all defaults.

[lefou]

What about an accessor to the defaults to make reusing easy:

val defaultGpgArgs = ...
def publish(...,  gpgArgs: Seq[String] = defaultGpgArgs, ...)

And a simple example in the docs, showing how to add a passphrase using the defaultsArgs + the passphrase args

[joan38]

Sounds good to me. What do you think @jodersky?

[jodersky]

Looks good! I agree with @lefou's suggestion too. Thanks for working on this!

[joan38]

Change pushed

[lefou]

Looks good to me

[lihaoyi]

This has broken publishing on the master branch:

Unknown arguments: "--gpgPassphrase" "[secure]"

@joan38 can you take a look?

[joan38]

@lihaoyi You need to pass --gpgArgs '--passphrase [secure]' instead of --gpgPassphrase [secure]

This is breaking change in terms of interface that is why I mentioned:

Not sure if we are ok to break the interface here. If not I can probably add back gpgPassphrase and gpgKeyName with a @deprecated and wire that to gpgArgs.

Let me know if you got it solved.