Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add toMap and toJson methods to BuildInfo #958

Merged
merged 3 commits into from
Sep 8, 2020
Merged

Conversation

sbly
Copy link
Contributor

@sbly sbly commented Sep 4, 2020

JSON is done via ujson-circe as this is what's already being used in the project itself

Copy link
Member

@lefou lefou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mill uses upickle for JSON serialization. The circe version is probably only present for some contrib module.

@lihaoyi
Copy link
Member

lihaoyi commented Sep 6, 2020

I don't think we should hardcode a ujson dependency in the BuildInfo modules. If anyone wants to convert it to JSON, calling upickle.default.write(BuildInfo.toMap) is trivial, and adding a ujson dependency bloats jars and leads to classpath conflicts

@lefou
Copy link
Member

lefou commented Sep 7, 2020

+1 for only adding the toMap method. But leaving out the toJson.

Edited: Removed the idea about pre-rendered JSON

@sbly
Copy link
Contributor Author

sbly commented Sep 8, 2020

@lihaoyi @lefou Thanks for the reviews! I removed the toJson method as recommended.

@lefou lefou merged commit 6a7a11a into com-lihaoyi:master Sep 8, 2020
@lefou lefou added this to the after 0.8.0 milestone Sep 8, 2020
@lefou
Copy link
Member

lefou commented Sep 8, 2020

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants