Drop scala 2.11, update scalajs, scala native, some dependancies #452
Conversation
build.sc
Outdated
| val scala3 = "3.1.3" | ||
| val scalaJS = "1.10.1" | ||
| val scalaNative = "0.4.5" | ||
| val scala3 = "3.2.2" |
There was a problem hiding this comment.
Is this needed for some reasons? It means we drop support for Scala 3.1, which is not what we want without reasons.
There was a problem hiding this comment.
Sorry for the delay. I think the reason here, was that I was attempting to get some of the extra ujson integrations working.
I think with scala at 3.1.3, this command will fail, because circe has been rolled forward to scala 3.2.2.
mill ujson.circe[3.1.3].compile
[error] class file io/circe/package.class is broken, reading aborted with class dotty.tools.tasty.UnpickleException
[error] TASTy signature has wrong version.
[error] expected: {majorVersion: 28, minorVersion: 1}
[error] found : {majorVersion: 28, minorVersion: 2}
[error]
So I guess, that in current state upickle this would fail to publish correctly. However, I think a better workaround may be to use circe 0.14.1. That at least appears to compile, and I would guess, is the preferred compromise - it is not rational for circe to drive the scala version upickle supports!
I'll put up the teeny tiniest of PRs.
There was a problem hiding this comment.
We might need to bump Scala 3 for other reasons, see #454
So let's wait for the other PRs to land before changing anything.
This PR sets out to make as few code changes as possible in order to move versions forward
It seems to compile and pass the tests - but mima fails. I'm don't honestly understand if that is problematic, or exactly how to go about fixing it - feedback welcome. This PR is the rider to this discussion;
#451