Enable fatal warnings and fix them all across codebase #457
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lihaoyi
approved these changes
Mar 11, 2023
- Delete `@deprecated` members
- Increase stack size for jvm to mitigate compiler stack overflow
- Introduce `IterableOnce` type alias to `TraversableOnce` in Scala 2.12
to fix deprecation in Scala 2.13 while maintaining Scala 2.12
compatibility
- Add `@nowarn("cat=deprecation")` in Scala 2 macro code
The message was the following: ``` the type test for scalajs.js.Array[scalajs.js.Any] cannot be checked at runtime ```
lolgab
force-pushed
the
fix-all-warnings
branch
from
713821e
to
93b4a14
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@deprecatedmembersIterableOncetype alias toTraversableOncein Scala 2.12 to fix deprecation in Scala 2.13 while maintaining Scala 2.12 compatibility@nowarn("cat=deprecation")in Scala 2 macro code