Fix ClassCastException on import given #472
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #469
The basic problem is that
superTypeReader
andsuperTypeWriter
were triggering for TypesT
andV
which were identical, meaning it was getting used even when not necessary due toimport upickle.default.given
increasing its implicit priority.This PR adds a
: SumOf
implicit requirement toV
, ensuring thatsuperTypeReader
andsuperTypeWriter
only trigger whenV
is a parentsealed trait/class/enum
type, won't trigger whenT =:= V
as acase class
, and thus the.asInstanceOf[TaggedReader[T]]
cast is valid