-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change the name of the payum-exemple extensions #10
Comments
if they are the same maybe we could have a |
Actually i'm thinking that the |
I agree about This considered, maybe the code shared between raw symfony and sylius should be stored under the |
Not actually all the extensions; For example this extension can be used without symfony : https://github.com/Combodo/CombodoPayumStripe/blob/master/doc/payum-example/src/AppBundle/Payment/StripeV3RequirementsFulfillerOnCaptureExtensions.php Oh well actually you are right ! To be fair something like that would be the best I suppose :
|
Hi @bruno-ds |
Sorry, |
Maybe the classes should be named differently than the ones in the sylius example?
Or it may be mentioned that they are the same?
Originally posted by @bruno-ds in #9
The text was updated successfully, but these errors were encountered: