Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change the name of the payum-exemple extensions #10

Closed
PyRowMan opened this issue Jul 26, 2019 · 6 comments · Fixed by #12
Closed

Change the name of the payum-exemple extensions #10

PyRowMan opened this issue Jul 26, 2019 · 6 comments · Fixed by #12

Comments

@PyRowMan
Copy link
Contributor

Maybe the classes should be named differently than the ones in the sylius example?
Or it may be mentioned that they are the same?

Originally posted by @bruno-ds in #9

@bruno-ds
Copy link
Contributor

if they are the same maybe we could have a /doc/examples-common directory where they are stored?

@PyRowMan
Copy link
Contributor Author

PyRowMan commented Jul 26, 2019

Actually i'm thinking that the /doc/payum-exemples directory should be named /doc/symfony-examples because payum is not dependent to symfony; therefore your /doc/common-examples directory could be named /doc/payum-examples ?

@bruno-ds
Copy link
Contributor

I agree about symfony-example,
for payum-example, well it remain quite dependent to symfony, for example using yii or laravel, I don't know if you'll be able to use the code contained in this dir.

This considered, maybe the code shared between raw symfony and sylius should be stored under the symfony-example directory?

@PyRowMan
Copy link
Contributor Author

Not actually all the extensions;

For example this extension can be used without symfony : https://github.com/Combodo/CombodoPayumStripe/blob/master/doc/payum-example/src/AppBundle/Payment/StripeV3RequirementsFulfillerOnCaptureExtensions.php

Oh well actually you are right ! To be fair something like that would be the best I suppose :

/doc/examples/symfony-examples/raw-examples
/doc/examples/symfony-examples/sylius-examples
/doc/examples/payum-examples

@PyRowMan
Copy link
Contributor Author

Hi @bruno-ds
Here is the future PR, will you have the time to take a little look ?

https://github.com/Combodo/CombodoPayumStripe/compare/master...PyRowMan:tree-examples-folder?expand=1

@bruno-ds
Copy link
Contributor

Sorry,
I'm In a urge, this will last for a couple of days,
Sorry, I promise that I'll look into it ASAP!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants