Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

comby doesn't work correctly with a single quote in haskell #217

Closed
Enr1g opened this issue Nov 27, 2020 · 5 comments
Closed

comby doesn't work correctly with a single quote in haskell #217

Enr1g opened this issue Nov 27, 2020 · 5 comments

Comments

@Enr1g
Copy link

Enr1g commented Nov 27, 2020

Describe the bug

A single quote in Haskell can be used not only as a delimeter for Char (e.g. "asdf" == ['a','s','d','f']) but also as a part of an identifier (e.g. s = 1; s' = s + 1). It seems that the current haskell matcher can't tell the second case from the first.

Reproducing

  • Works as intended with a simple example: here.
  • Doesn't match if there is a single quote in an identifier somewhere prior: here.
  • Matches again if a closing quote is added (thus restoring "quote balance"): here.

Expected behavior

To match hello in the second example.

@rvantonder
Copy link
Member

Hey, thanks for the note. You're right, the matcher is too strict here, expecting ' to be balanced. I've made it less strict.

@s0kil
Copy link

s0kil commented Feb 22, 2021

Can be closed?

@rvantonder
Copy link
Member

This is fixed, but not released yet. I'll release an updated version today.

@s0kil
Copy link

s0kil commented Feb 22, 2021

@rvantonder I've seen you just released the new version, is there a change log somewhere?

@rvantonder
Copy link
Member

Hey @s0kil I was just writing it up and editing the release notes--I should probably have done that before publishing :-) Check out https://github.com/comby-tools/comby/releases/tag/1.1.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants