Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build(deps): bump github.com/linxGnu/grocksdb from 1.8.10 to 1.8.11 #119

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Jan 11, 2024

Bumps github.com/linxGnu/grocksdb from 1.8.10 to 1.8.11.

Release notes

Sourced from github.com/linxGnu/grocksdb's releases.

RocksDB 8.9.1

What's Changed

Full Changelog: linxGnu/grocksdb@v1.8.10...v1.8.11

Commits

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

@dependabot dependabot bot requested a review from a team as a code owner January 11, 2024 11:21
@dependabot dependabot bot added the dependencies Pull requests that update a dependency file label Jan 11, 2024
@faddat
Copy link
Contributor

faddat commented Jan 15, 2024

I also approve, can we merge? For the tests to pass we need to clear the certs then regenerate them. I will make a separate PR that does that. Then merge that into this using @dependabot recreate. Or they will never work. Because remotedb has certs. Because I don't know why.

OR

just forget rocks because it crosses cgo. (that is a link to an amazing paper and the reason pebble exists. No one would write a rocks clone in go if there was no need to.

@faddat
Copy link
Contributor

faddat commented Jan 15, 2024

Merge #120 into #119 or first into main and then merge main into #119 and it will pass tests again.

@faddat
Copy link
Contributor

faddat commented Jan 24, 2024

@dependabot rebase

Copy link
Contributor Author

dependabot bot commented on behalf of github Jan 24, 2024

Sorry, only users with push access can use that command.

@melekes
Copy link
Contributor

melekes commented Jan 24, 2024

https://github.com/dependabot rebase

@dependabot dependabot bot force-pushed the dependabot/go_modules/github.com/linxGnu/grocksdb-1.8.11 branch from 27ed1c4 to 68846f1 Compare January 24, 2024 12:14
Bumps [github.com/linxGnu/grocksdb](https://github.com/linxGnu/grocksdb) from 1.8.10 to 1.8.11.
- [Release notes](https://github.com/linxGnu/grocksdb/releases)
- [Commits](linxGnu/grocksdb@v1.8.10...v1.8.11)

---
updated-dependencies:
- dependency-name: github.com/linxGnu/grocksdb
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot dependabot bot force-pushed the dependabot/go_modules/github.com/linxGnu/grocksdb-1.8.11 branch from 68846f1 to 4a654a7 Compare January 24, 2024 12:23
@faddat
Copy link
Contributor

faddat commented Jan 24, 2024

I'd prefer to just merge #123 instead, which contains the Docker changes needed for this PR to work.

@melekes
Copy link
Contributor

melekes commented Jan 24, 2024

# github.com/linxGnu/grocksdb
/go/pkg/mod/github.com/linx!gnu/grocksdb@v1.8.11/cf_metadata.go:99:35: could not determine kind of name for C.rocksdb_sst_file_metadata_get_directory

@melekes
Copy link
Contributor

melekes commented Jan 24, 2024

Closing in favor of #123

@melekes melekes closed this Jan 24, 2024
Copy link
Contributor Author

dependabot bot commented on behalf of github Jan 24, 2024

OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor version, let me know by commenting @dependabot ignore this major version or @dependabot ignore this minor version. You can also ignore all major, minor, or patch releases for a dependency by adding an ignore condition with the desired update_types to your config file.

If you change your mind, just re-open this PR and I'll resolve any conflicts on it.

@dependabot dependabot bot deleted the dependabot/go_modules/github.com/linxGnu/grocksdb-1.8.11 branch January 24, 2024 15:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants