Skip to content

Commit

Permalink
feat(proto)!: replace pub_key with pub_key_type (#2890)
Browse files Browse the repository at this point in the history
and `pub_key_bytes` in `privval.PubKeyResponse`, `types.Validator` and
`types.SimpleValidator`.

Closes #2878
Follow-up to #2843
<!--

Please add a reference to the issue that this PR addresses and indicate
which
files are most critical to review. If it fully addresses a particular
issue,
please include "Closes #XXX" (where "XXX" is the issue number).

If this PR is non-trivial/large/complex, please ensure that you have
either
created an issue that the team's had a chance to respond to, or had some
discussion with the team prior to submitting substantial pull requests.
The team
can be reached via GitHub Discussions or the Cosmos Network Discord
server in
the #cometbft channel. GitHub Discussions is preferred over Discord as
it
allows us to keep track of conversations topically.
https://github.com/cometbft/cometbft/discussions

If the work in this PR is not aligned with the team's current
priorities, please
be advised that it may take some time before it is merged - especially
if it has
not yet been discussed with the team.

See the project board for the team's current priorities:
https://github.com/orgs/cometbft/projects/1

-->

---

#### PR checklist

- [x] Tests written/updated
- [x] Changelog entry added in `.changelog` (we use
[unclog](https://github.com/informalsystems/unclog) to manage our
changelog)
- [ ] Updated relevant documentation (`docs/` or `spec/`) and code
comments
- [x] Title follows the [Conventional
Commits](https://www.conventionalcommits.org/en/v1.0.0/) spec

---------

Co-authored-by: Sergio Mena <sergio@informal.systems>
(cherry picked from commit d342b3a)
  • Loading branch information
melekes authored and mergify[bot] committed Apr 29, 2024
1 parent bf32cf1 commit 2381160
Show file tree
Hide file tree
Showing 11 changed files with 406 additions and 264 deletions.
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
- [`proto/privval`] Replace `pub_key` with `pub_key_type` and `pub_key_bytes` in
`PubKeyResponse` ([\#2878](https://github.com/cometbft/cometbft/issues/2878))
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
- [`proto/types`] Replace `pub_key` with `pub_key_type` and `pub_key_bytes` in
`Validator` and `SimpleValidator` ([\#2878](https://github.com/cometbft/cometbft/issues/2878))
248 changes: 149 additions & 99 deletions api/cometbft/privval/v1/types.pb.go

Large diffs are not rendered by default.

Loading

0 comments on commit 2381160

Please sign in to comment.