feat(proto)!: replace pub_key with pub_key_type
#2890
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
and `pub_key_bytes` in `privval.PubKeyResponse`, `types.Validator` and `types.SimpleValidator`. Closes #2878
melekes
force-pushed
the
2878-remove-pubkey-all
branch
from
7063691
to
bb31051
Compare
sergio-mena
reviewed
Apr 26, 2024
.changelog/unreleased/breaking-changes/2890-proto-privval-get-pubkey-response-public-key.md
Outdated
Show resolved
Hide resolved
sergio-mena
reviewed
Apr 26, 2024
.changelog/unreleased/breaking-changes/2890-proto-types-validator-public-key.md
Outdated
Show resolved
Hide resolved
sergio-mena
reviewed
Apr 26, 2024
sergio-mena
reviewed
Apr 26, 2024
| @@ -20,8 +19,11 @@ message PubKeyRequest { | |||
|
|
|||
| // PubKeyResponse is a response message containing the public key. | |||
| message PubKeyResponse { | |||
| cometbft.crypto.v1.PublicKey pub_key = 1 [(gogoproto.nullable) = false]; | |||
There was a problem hiding this comment.
We need to discuss how we'll be managing the proto versions from now on... the v1 proto versions match CometBFT v1.0.0, but now these changes (and other we're doing on main) should trigger a bump in the proto version, I think.
TBH, I haven't given it a deep thought... it would probably be worth discussing in our team meeting.
This shouldn't be blocking this PR, BTW.
There was a problem hiding this comment.
Since we're backporting this to v1, no version bump is needed. That was my thought, at least.
There was a problem hiding this comment.
Oh, of course... spot on!
sergio-mena
reviewed
Apr 26, 2024
Co-authored-by: Sergio Mena <sergio@informal.systems>
mergify bot
pushed a commit
that referenced
this pull request
Apr 29, 2024
and `pub_key_bytes` in `privval.PubKeyResponse`, `types.Validator` and `types.SimpleValidator`. Closes #2878 Follow-up to #2843 <!-- Please add a reference to the issue that this PR addresses and indicate which files are most critical to review. If it fully addresses a particular issue, please include "Closes #XXX" (where "XXX" is the issue number). If this PR is non-trivial/large/complex, please ensure that you have either created an issue that the team's had a chance to respond to, or had some discussion with the team prior to submitting substantial pull requests. The team can be reached via GitHub Discussions or the Cosmos Network Discord server in the #cometbft channel. GitHub Discussions is preferred over Discord as it allows us to keep track of conversations topically. https://github.com/cometbft/cometbft/discussions If the work in this PR is not aligned with the team's current priorities, please be advised that it may take some time before it is merged - especially if it has not yet been discussed with the team. See the project board for the team's current priorities: https://github.com/orgs/cometbft/projects/1 --> --- #### PR checklist - [x] Tests written/updated - [x] Changelog entry added in `.changelog` (we use [unclog](https://github.com/informalsystems/unclog) to manage our changelog) - [ ] Updated relevant documentation (`docs/` or `spec/`) and code comments - [x] Title follows the [Conventional Commits](https://www.conventionalcommits.org/en/v1.0.0/) spec --------- Co-authored-by: Sergio Mena <sergio@informal.systems> (cherry picked from commit d342b3a)
4 tasks
melekes
added a commit
that referenced
this pull request
Apr 29, 2024
…2922) and `pub_key_bytes` in `privval.PubKeyResponse`, `types.Validator` and `types.SimpleValidator`. Closes #2878 Follow-up to #2843 --- #### PR checklist - [x] Tests written/updated - [x] Changelog entry added in `.changelog` (we use [unclog](https://github.com/informalsystems/unclog) to manage our changelog) - [ ] Updated relevant documentation (`docs/` or `spec/`) and code comments - [x] Title follows the [Conventional Commits](https://www.conventionalcommits.org/en/v1.0.0/) spec <hr>This is an automatic backport of pull request #2890 done by [Mergify](https://mergify.com). Co-authored-by: Anton Kaliaev <anton.kalyaev@gmail.com>
This was referenced May 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
and
pub_key_bytesinprivval.PubKeyResponse,types.Validatorandtypes.SimpleValidator.Closes #2878
Follow-up to #2843
PR checklist
.changelog(we use unclog to manage our changelog)docs/orspec/) and code comments