Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documentation Guide Error #2069

Closed
deruelle opened this issue Jan 19, 2024 · 1 comment
Closed

Documentation Guide Error #2069

deruelle opened this issue Jan 19, 2024 · 1 comment
Labels
bug Something isn't working needs-triage This issue/PR has not yet been triaged by the team.
Milestone

Comments

@deruelle
Copy link
Contributor

Bug Report

Setup

CometBFT version (use cometbft version or git rev-parse --verify HEAD if installed from source): 0.38.0

Have you tried the latest version: yes

ABCI app (name for built-in, URL for self-written if it's publicly available):

Environment:

  • OS (e.g. from /etc/os-release): Ubuntu 22.04.3 LTS
  • Install tools:
  • Others: go version go1.21.6 linux/amd64

node command runtime flags:

Config

What happened?

When trying to run any of the guides at https://docs.cometbft.com/v0.38/guides/go#13-writing-a-cometbft-application or https://docs.cometbft.com/v0.38/guides/go-built-in#13-writing-a-cometbft-application, the compilation triggers errors, see Logs section below

What did you expect to happen?

Build without any issues. Fixing the import by adding context is fixing the build issue

How to reproduce it

Follow the steps in the guide.

Logs

$ go build

# kvstore
./app.go:15:39: undefined: context
./app.go:19:40: undefined: context
./app.go:23:42: undefined: context
./app.go:27:44: undefined: context
./app.go:31:50: undefined: context
./app.go:35:50: undefined: context
./app.go:39:48: undefined: context
./app.go:43:40: undefined: context
./app.go:47:48: undefined: context
./app.go:59:53: undefined: context
./app.go:47:48: too many errors

For the non built-in app, once the import is fixed the following error can be seen

go build
# kvstore
./app.go:25:45: undefined: code

dump_consensus_state output

Anything else we need to know

@deruelle deruelle added bug Something isn't working needs-triage This issue/PR has not yet been triaged by the team. labels Jan 19, 2024
@deruelle
Copy link
Contributor Author

deruelle commented Jan 19, 2024

I'll provide a PR for the guide documentation

@melekes melekes closed this as completed Jan 22, 2024
@adizere adizere added this to CometBFT Jan 23, 2024
@github-project-automation github-project-automation bot moved this to Todo in CometBFT Jan 23, 2024
@adizere adizere added this to the 2024-Q1 milestone Jan 23, 2024
@melekes melekes moved this from Todo to Done in CometBFT Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working needs-triage This issue/PR has not yet been triaged by the team.
Projects
Status: Done
Development

No branches or pull requests

3 participants