Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use case: Consensus engine developers #43

Closed
2 tasks
lasarojc opened this issue Dec 23, 2022 · 1 comment
Closed
2 tasks

Use case: Consensus engine developers #43

lasarojc opened this issue Dec 23, 2022 · 1 comment
Labels
major-priority A major, long-running priority for the team P:consensus-engine-devs Priority: Better support consensus engine developers tracking A complex issue broken down into sub-problems

Comments

@lasarojc
Copy link
Contributor

lasarojc commented Dec 23, 2022 •
edited by thanethomson

This is a general tracking issue for efforts towards to refactor Comet so as to be more amenable to being used by consensus engine developers.

At present, many such developers have to fork Comet to accomplish their aims.

Originally tendermint/tendermint#9878
@lasarojc lasarojc added major-priority A major, long-running priority for the team tracking A complex issue broken down into sub-problems labels Dec 23, 2022
@lasarojc lasarojc mentioned this issue Dec 23, 2022
Open
20 tasks
@thanethomson thanethomson added P:consensus-engine-devs Priority: Better support consensus engine developers and removed devx labels Jun 20, 2023
@adizere
Copy link
Member

adizere commented Jan 12, 2024

Closing to simplify tracking of major priorities. See instead:

@adizere adizere closed this as completed Jan 12, 2024
cometcrafter pushed a commit to graphprotocol/cometbft that referenced this issue May 13, 2024
@mergify @czarcas7ic
perf(internal/bits): Speedup extended commit.BitArray() (backport com…
8855295 
…etbft#2959) (cometbft#2983) (cometbft#43) (cometbft#55)

Speedup ExtendedCommit.BitArray() by making a direct constructor that
does not go through mutexes. I expect this to be a 10x performance
improvement. (It also removes the duffcopies and reduces setIndex
proportion of time here)

This removes this time (which is mostly coming from mutex calls):

![image](https://github.com/cometbft/cometbft/assets/6440154/da11d57d-6bea-40ea-a0fa-9209ea3e22f8)

Later on we should instead make an API that lets us randomly sample from
a bit array with no bit array copying needed. (But that makes the
interface messier)

---

#### PR checklist

- [x] Tests written/updated
- [x] Changelog entry added in `.changelog` (we use
[unclog](https://github.com/informalsystems/unclog) to manage our
changelog)
- [x] Updated relevant documentation (`docs/` or `spec/`) and code
comments
- [x] Title follows the [Conventional
Commits](https://www.conventionalcommits.org/en/v1.0.0/) spec
<hr>This is an automatic backport of pull request cometbft#2959 done by
[Mergify](https://mergify.com).

---------

Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
Co-authored-by: Dev Ojha <ValarDragon@users.noreply.github.com>
Co-authored-by: Anton Kaliaev <anton.kalyaev@gmail.com>
(cherry picked from commit 88c490f)

Co-authored-by: Adam Tucker <adam@osmosis.team>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
major-priority A major, long-running priority for the team P:consensus-engine-devs Priority: Better support consensus engine developers tracking A complex issue broken down into sub-problems
Projects
No open projects
CometBFT 2023
Status: Todo
Milestone
No milestone
Development

No branches or pull requests
3 participants
@thanethomson @adizere @lasarojc