faddat/reversions for fixed length #2
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Add `CMT_HOME` (or remove it?) (cometbft#983) Closes cometbft#982 Added `CMT_HOME` everywhere `CMTHOME` is used. ### Notes to reviewers This could be fixed the opposite way, by removing the only reference to `CMT_HOME` in the code, and also the reference in `UPGRADING.md` (two lines of code). However, the reference in `UPGRADING.md`, which is part of our documentation, is already present in `v0.34.x` (not in `v0.37.x` though!). That's why this PR introduces `CMT_HOME` to work in equal conditions as `CMTHOME`. If reviewers lean toward removing `CMT_HOME` from the doc in `v0.34.x` (and unreleased `v0.38.x` and `main`), I can do it easily. --- #### PR checklist - [x] Tests written/updated - [ ] Changelog entry added in `.changelog` (we use [unclog](https://github.com/informalsystems/unclog) to manage our changelog) - [ ] Updated relevant documentation (`docs/` or `spec/`) and code comments (cherry picked from commit b7be568) # Conflicts: # UPGRADING.md # cmd/cometbft/commands/root_test.go * Revert "Add `CMT_HOME` (or remove it?) (cometbft#983)" * Add `CMT_HOME` (or remove it?) (cometbft#983) Closes cometbft#982 Added `CMT_HOME` everywhere `CMTHOME` is used. This could be fixed the opposite way, by removing the only reference to `CMT_HOME` in the code, and also the reference in `UPGRADING.md` (two lines of code). However, the reference in `UPGRADING.md`, which is part of our documentation, is already present in `v0.34.x` (not in `v0.37.x` though!). That's why this PR introduces `CMT_HOME` to work in equal conditions as `CMTHOME`. If reviewers lean toward removing `CMT_HOME` from the doc in `v0.34.x` (and unreleased `v0.38.x` and `main`), I can do it easily. --- - [x] Tests written/updated - [ ] Changelog entry added in `.changelog` (we use [unclog](https://github.com/informalsystems/unclog) to manage our changelog) - [ ] Updated relevant documentation (`docs/` or `spec/`) and code comments --------- Co-authored-by: Sergio Mena <sergio@informal.systems>
…metbft#1029) Bumps [bufbuild/buf-setup-action](https://github.com/bufbuild/buf-setup-action) from 1.21.0 to 1.22.0. - [Release notes](https://github.com/bufbuild/buf-setup-action/releases) - [Commits](bufbuild/buf-setup-action@v1.21.0...v1.22.0) --- updated-dependencies: - dependency-name: bufbuild/buf-setup-action dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
…ometbft#1046) Closes cometbft#666 This PR adds double quotes to `path` param of `/abci_query` endpoint. --- #### PR checklist - [ ] Tests written/updated - [ ] Changelog entry added in `.changelog` (we use [unclog](https://github.com/informalsystems/unclog) to manage our changelog) - [ ] Updated relevant documentation (`docs/` or `spec/`) and code comments (cherry picked from commit f6f13b1) Co-authored-by: Steven Ferrer <steven.r.ferrer@gmail.com>
…different from the one returned in the preceding prepareProposal (backport cometbft#1033) (cometbft#1053) * Clarifies that processProposal may be called for set of transactions different from the one returned in the preceding prepareProposal (cometbft#1033) If a proposer fails after calling prepareProposal and before calling processProposal, then the following may happen upon restarting: - if failed before signing another message, then will invoke prepareProposal again, sign a new block, probably empty, and propose it; - if failed after signing a proposal but before writing the proposal message into the WAL, then will invoke prepareProposal and produce a new, probably empty block, [fail to sign it](https://github.com/cometbft/cometbft/blob/2789a59a9cc61c6ea56a6b266eeadf0f26ca2456/consensus/state.go#L1221), and not invoke processProposal; prevote timeouts will ensure the CometBFT is not stuck; - if failed after writing the proposal message to the WAL, then will invoke prepareProposal, produce a new, probably empty block, fail to sign it, and invoke processProposal with the block signed before crashing. --- #### PR checklist - [ ] Tests written/updated - [ ] Changelog entry added in `.changelog` (we use [unclog](https://github.com/informalsystems/unclog) to manage our changelog) - [x] Updated relevant documentation (`docs/` or `spec/`) and code comments (cherry picked from commit b23ef56) # Conflicts: # spec/abci/abci++_basic_concepts.md # spec/abci/abci++_comet_expected_behavior.md * solving cherry pick conflicts * solving cherry pick conflicts --------- Co-authored-by: Lasaro <lasaro@informal.systems>
This is backport of three PRs originally merged against main: * spec/p2p: Specify the operation of a Reactor (cometbft#714) * spec/p2p: document the p2p API used by Reactors (cometbft#851) * spec/p2p: new structure for the p2p specification (cometbft#966) Co-authored-by: Josef Widder <44643235+josef-widder@users.noreply.github.com> Co-authored-by: Lasaro <lasaro@informal.systems> Co-authored-by: Sergio Mena <sergio@informal.systems>
…metbft#1063) Bumps [bufbuild/buf-setup-action](https://github.com/bufbuild/buf-setup-action) from 1.22.0 to 1.23.1. - [Release notes](https://github.com/bufbuild/buf-setup-action/releases) - [Commits](bufbuild/buf-setup-action@v1.22.0...v1.23.1) --- updated-dependencies: - dependency-name: bufbuild/buf-setup-action dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
…etbft#1062) Bumps [docker/setup-buildx-action](https://github.com/docker/setup-buildx-action) from 2.7.0 to 2.8.0. - [Release notes](https://github.com/docker/setup-buildx-action/releases) - [Commits](docker/setup-buildx-action@v2.7.0...v2.8.0) --- updated-dependencies: - dependency-name: docker/setup-buildx-action dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
…etbft#1104) Bumps [docker/setup-buildx-action](https://github.com/docker/setup-buildx-action) from 2.8.0 to 2.9.0. - [Release notes](https://github.com/docker/setup-buildx-action/releases) - [Commits](docker/setup-buildx-action@v2.8.0...v2.9.0) --- updated-dependencies: - dependency-name: docker/setup-buildx-action dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
…etbft#1129) Bumps [docker/setup-buildx-action](https://github.com/docker/setup-buildx-action) from 2.9.0 to 2.9.1. - [Release notes](https://github.com/docker/setup-buildx-action/releases) - [Commits](docker/setup-buildx-action@v2.9.0...v2.9.1) --- updated-dependencies: - dependency-name: docker/setup-buildx-action dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
…metbft#1130) Bumps [bufbuild/buf-setup-action](https://github.com/bufbuild/buf-setup-action) from 1.23.1 to 1.24.0. - [Release notes](https://github.com/bufbuild/buf-setup-action/releases) - [Commits](bufbuild/buf-setup-action@v1.23.1...v1.24.0) --- updated-dependencies: - dependency-name: bufbuild/buf-setup-action dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
…metbft#1158) Bumps [bufbuild/buf-setup-action](https://github.com/bufbuild/buf-setup-action) from 1.24.0 to 1.25.0. - [Release notes](https://github.com/bufbuild/buf-setup-action/releases) - [Commits](bufbuild/buf-setup-action@v1.24.0...v1.25.0) --- updated-dependencies: - dependency-name: bufbuild/buf-setup-action dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
…metbft#1219) Bumps [bufbuild/buf-setup-action](https://github.com/bufbuild/buf-setup-action) from 1.25.0 to 1.25.1. - [Release notes](https://github.com/bufbuild/buf-setup-action/releases) - [Commits](bufbuild/buf-setup-action@v1.25.0...v1.25.1) --- updated-dependencies: - dependency-name: bufbuild/buf-setup-action dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* CV OnStop close evidenceStore * CV OnStop print db close * CV add changelog * CV update changelog with attribution (cherry picked from commit 48335a0) Co-authored-by: Chill Validation <92176880+chillyvee@users.noreply.github.com> Co-authored-by: Sergio Mena <sergio@informal.systems>
…ometbft#1079) (cometbft#1221) * Log proposer's address when correctly accepting a proposal (cometbft#1079) * Log proposer when logging received proposal * Addressed review comments * Promote updates to validator to Info level (cherry picked from commit cf23082) # Conflicts: # consensus/state.go * Revert "Log proposer's address when correctly accepting a proposal (cometbft#1079)" This reverts commit b2aaa8f. * Log proposer's address when correctly accepting a proposal (cometbft#1079) * Log proposer when logging received proposal * Addressed review comments * Promote updates to validator to Info level --------- Co-authored-by: Sergio Mena <sergio@informal.systems>
…metbft#1237) Bumps [bufbuild/buf-setup-action](https://github.com/bufbuild/buf-setup-action) from 1.25.1 to 1.26.0. - [Release notes](https://github.com/bufbuild/buf-setup-action/releases) - [Commits](bufbuild/buf-setup-action@v1.25.1...v1.26.0) --- updated-dependencies: - dependency-name: bufbuild/buf-setup-action dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
…metbft#1274) Bumps [bufbuild/buf-setup-action](https://github.com/bufbuild/buf-setup-action) from 1.26.0 to 1.26.1. - [Release notes](https://github.com/bufbuild/buf-setup-action/releases) - [Commits](bufbuild/buf-setup-action@v1.26.0...v1.26.1) --- updated-dependencies: - dependency-name: bufbuild/buf-setup-action dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
…metbft#1301) Bumps [docker/setup-buildx-action](https://github.com/docker/setup-buildx-action) from 2.9.1 to 2.10.0. - [Release notes](https://github.com/docker/setup-buildx-action/releases) - [Commits](docker/setup-buildx-action@v2.9.1...v2.10.0) --- updated-dependencies: - dependency-name: docker/setup-buildx-action dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
it'll make the handshake work with graceful shutdown(see: cosmos/cosmos-sdk#16202) handshake could be a long running process if there are many local blocks to replay, for example we use it to do profiling. Hope we can backport this to 0.34.x. --- - [ ] Tests written/updated - [ ] Changelog entry added in `.changelog` (we use [unclog](https://github.com/informalsystems/unclog) to manage our changelog) - [ ] Updated relevant documentation (`docs/` or `spec/`) and code comments
…bft#1314) Bumps [docker/build-push-action](https://github.com/docker/build-push-action) from 4.1.1 to 4.2.1. - [Release notes](https://github.com/docker/build-push-action/releases) - [Commits](docker/build-push-action@v4.1.1...v4.2.1) --- updated-dependencies: - dependency-name: docker/build-push-action dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [actions/checkout](https://github.com/actions/checkout) from 3 to 4. - [Release notes](https://github.com/actions/checkout/releases) - [Changelog](https://github.com/actions/checkout/blob/main/CHANGELOG.md) - [Commits](actions/checkout@v3...v4) --- updated-dependencies: - dependency-name: actions/checkout dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Sergio Mena <sergio@informal.systems>
…bft#1356) Bumps [docker/build-push-action](https://github.com/docker/build-push-action) from 4.2.1 to 5.0.0. - [Release notes](https://github.com/docker/build-push-action/releases) - [Commits](docker/build-push-action@v4.2.1...v5.0.0) --- updated-dependencies: - dependency-name: docker/build-push-action dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
) Bumps [docker/login-action](https://github.com/docker/login-action) from 2.2.0 to 3.0.0. - [Release notes](https://github.com/docker/login-action/releases) - [Commits](docker/login-action@v2.2.0...v3.0.0) --- updated-dependencies: - dependency-name: docker/login-action dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
…metbft#1358) Bumps [docker/setup-buildx-action](https://github.com/docker/setup-buildx-action) from 2.10.0 to 3.0.0. - [Release notes](https://github.com/docker/setup-buildx-action/releases) - [Commits](docker/setup-buildx-action@v2.10.0...v3.0.0) --- updated-dependencies: - dependency-name: docker/setup-buildx-action dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
…1357) Bumps [goreleaser/goreleaser-action](https://github.com/goreleaser/goreleaser-action) from 4 to 5. - [Release notes](https://github.com/goreleaser/goreleaser-action/releases) - [Commits](goreleaser/goreleaser-action@v4...v5) --- updated-dependencies: - dependency-name: goreleaser/goreleaser-action dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Sergio Mena <sergio@informal.systems>
(cherry picked from commit dad1253) Co-authored-by: Aliasgar Merchant <44069404+alijnmerchant21@users.noreply.github.com>
…#1405) (cometbft#1410) * doc: improve documentation of BlockParams.MaxBytes (cometbft#1405) * spec: comment on BlockParams.MaxBytes and timeouts * spec/abci: link to consensus timeouts doc fixed * spec/abci: comment on timeout parameters moved down * spec: advice to wind down default BlockParams.MaxBytes * spec: more on winding down default BlockParams.MaxBytes * spec: fixes on winding down default BlockParams.MaxBytes * spec: nit pic on winding down default BlockParams.MaxBytes * Applying @sergio-mena suggestion Co-authored-by: Sergio Mena <sergio@informal.systems> * Applying @sergio-mena suggestion Co-authored-by: Sergio Mena <sergio@informal.systems> * Update spec/abci/abci++_app_requirements.md Co-authored-by: glnro <8335464+glnro@users.noreply.github.com> --------- Co-authored-by: Sergio Mena <sergio@informal.systems> Co-authored-by: glnro <8335464+glnro@users.noreply.github.com> (cherry picked from commit 80648c4) # Conflicts: # spec/abci/abci++_app_requirements.md * spec/abci: fix conflicts when backporting * Fixing typo on backported file --------- Co-authored-by: Daniel <daniel.cason@informal.systems>
* update language (cometbft#1263) Using "a validator should" instead of 'we' (cherry picked from commit 3d1c36d) # Conflicts: # docs/core/configuration.md * resolves the conflicts --------- Co-authored-by: Aliasgar Merchant <44069404+alijnmerchant21@users.noreply.github.com> Co-authored-by: lasaro <lasaro@informal.systems>
…metbft#1657) Bumps [bufbuild/buf-setup-action](https://github.com/bufbuild/buf-setup-action) from 1.28.0 to 1.28.1. - [Release notes](https://github.com/bufbuild/buf-setup-action/releases) - [Commits](bufbuild/buf-setup-action@v1.28.0...v1.28.1) --- updated-dependencies: - dependency-name: bufbuild/buf-setup-action dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* mempool: add `nop` mempool (cometbft#1643) * add `nop` mempool See [ADR-111](cometbft#1585) * implement NopMempool and NopMempoolReactor modify node.go logic I had to add NopMempoolReactor to pass it to RPC in order not to change it. * check config instead of asserting for nil * start writing docs * add changelog * move changelog * expand docs * remove unused func arguments * add simple test * make linter happy again * doc fixes Co-authored-by: Sergio Mena <sergio@informal.systems> * rename mempoolReactor to waitSyncP2PReactor * improve changelog message * allow empty string for backwards compatibility cometbft#1643 (comment) * make ErrNotAllowed private * mention `create_empty_blocks` in toml https://github.com/cometbft/cometbft/pull/1643/files#r1400434715 * return nil instead of closed channel https://github.com/cometbft/cometbft/pull/1643/files#r1400252575 The reader will block forever, which is exactly what we need. * grammar fixes Co-authored-by: lasaro <lasaro@informal.systems> * update changelog entry * adapt ADR to implementation * remove old ToC entry --------- Co-authored-by: Andy Nogueira <me@andynogueira.dev> Co-authored-by: Sergio Mena <sergio@informal.systems> Co-authored-by: lasaro <lasaro@informal.systems> (cherry picked from commit bc83503) # Conflicts: # config/config.go # config/toml.go # docs/architecture/README.md # docs/architecture/adr-111-nop-mempool.md # docs/core/configuration.md # node/node.go # node/setup.go * fix merge conflicts * add a missing ToC line --------- Co-authored-by: Anton Kaliaev <anton.kalyaev@gmail.com>
…ometbft#1686) * docs: various small improvements (part 2) (cometbft#1683) * docs: fix the number of connections CometBFT opens to the ABCI app * docs: fix link formatting * docs: make it explicit that default is TCP for ABCI * docs: replace 'supermajority' with 2/3+ 2/3+ is easier to understand. also this is the first time the reader is seeing the word 'supermajority', which might be confusing without the defition. The defition for supermajority is absent (maybe it's in the spec though) * add a link to jq * suggestions from Lasaro (cherry picked from commit 96abada) # Conflicts: # docs/app-dev/indexing-transactions.md # docs/core/block-structure.md * fixes after merge --------- Co-authored-by: Anton Kaliaev <anton.kalyaev@gmail.com>
…ometbft#1689) * Do not block indefinitely on the semaphore (cometbft#1654) * Do not block indefinitely on the semaphore * Cancel the context, irrespective of the flow followed * Makes the code more readable * Improving comment * make linter happy * Updating comments to match * Commenting out `select` and leaving it as TODO for when Contexts are more widely used * Cleaned up comments (cherry picked from commit 2679498) # Conflicts: # config/config.go # config/toml.go # test/e2e/pkg/manifest.go * Backports cometbft#1558 and cometbft#1584 to 0.38.x (cometbft#1592) * Experimental - Reduce # of connections effectively used to gossip transactions out (cometbft#1558) * maxpeers for mempool * mempool: fix max_peers bcast routine active flag * Use semaphore to limit concurrency * Rename MaxPeers to MaxOutboundPeers * Add max_outbound_peers to config toml template * Rename in error message * Renams the parameter to highlight its experimental nature. Extend the AddPeer method to return an error. Moves the semaphone to outside the broadcast routine * reverting the addition of error to AddPeer. It fails if the context is done and handling this case will be done some other time, when an actual context is passed into acquire. * reverting the addition of error to AddPeer. It fails if the context is done and handling this case will be done some other time, when an actual context is passed into acquire. * Fixing lint issue * renaming semaphore to something more meaningful * make default value 0, which is the same as the current behavior. 10 is the recommended value. * adding new flag to manifest.go * Adding changelog * Improve the description of the parameter in the generated config file. * Add metric to track the current number of active connections. * Change metric to gauge type and rename it. * e2e: Allow disabling the PEX reactor on all nodes in the testnet * Apply suggestions from code review Co-authored-by: Sergio Mena <sergio@informal.systems> * Update config/config.go comment * fix lint error * Improve config description * Rename metric (remove experimental prefix) * Add unit test * Improve unit test * Update mempool/reactor.go comment --------- Co-authored-by: Ethan Buchman <ethan@coinculture.info> Co-authored-by: Daniel Cason <daniel.cason@informal.systems> Co-authored-by: lasarojc <lasaro@informal.systems> Co-authored-by: hvanz <hernan.vanzetto@gmail.com> Co-authored-by: Andy Nogueira <me@andynogueira.dev> Co-authored-by: Sergio Mena <sergio@informal.systems> * Updating test file, leaving it broken for now * mempool: Limit gossip connections to persistent and non-persistent peers (experimental) (cometbft#1584) * Ignore persistent peers from limiting of outbound connections * Update 1558-experimental-gossip-limiting.md Update changeling * Fix typo in mempool/metrics.go * Use two independent configs and semaphores for persistent and non-persistent peers * Forgot to rename in test * Update metric description * Rename semaphores * Add comment to unit test --------- Co-authored-by: hvanz <hernan.vanzetto@gmail.com> * Reverting to old way of reporting errors * Reverting change that shouldn't have been included in cherry-pick * Reverting tests to use older functions * fix rebase merge --------- Co-authored-by: Adi Seredinschi <adizere@gmail.com> Co-authored-by: Ethan Buchman <ethan@coinculture.info> Co-authored-by: Daniel Cason <daniel.cason@informal.systems> Co-authored-by: hvanz <hernan.vanzetto@gmail.com> Co-authored-by: Andy Nogueira <me@andynogueira.dev> Co-authored-by: Sergio Mena <sergio@informal.systems> * Fixes conflict. --------- Co-authored-by: lasaro <lasaro@informal.systems> Co-authored-by: Adi Seredinschi <adizere@gmail.com> Co-authored-by: Ethan Buchman <ethan@coinculture.info> Co-authored-by: Daniel Cason <daniel.cason@informal.systems> Co-authored-by: hvanz <hernan.vanzetto@gmail.com> Co-authored-by: Andy Nogueira <me@andynogueira.dev> Co-authored-by: Sergio Mena <sergio@informal.systems>
* version: Bump version to v0.37.4 * Add changelog entry * unclog release * unclog build * Format changelog summary (line wrap) Signed-off-by: Thane Thomson <connect@thanethomson.com> * Add note about reverting minimum Go version change Signed-off-by: Thane Thomson <connect@thanethomson.com> * Build changelog Signed-off-by: Thane Thomson <connect@thanethomson.com> --------- Signed-off-by: Thane Thomson <connect@thanethomson.com> Co-authored-by: Thane Thomson <connect@thanethomson.com>
…etbft#1722) * types: validate Validator#Address field (cometbft#1715) * types: validate Validator#Address field * fix TestProposerSelection3 * add a changelog entry * fix two more tests * Update .changelog/unreleased/improvements/1715-validate-validator-address Co-authored-by: Thane Thomson <connect@thanethomson.com> --------- Co-authored-by: Thane Thomson <connect@thanethomson.com> (cherry picked from commit 63fe7bf) # Conflicts: # internal/state/store_test.go # internal/store/store_test.go * fix conflicts * fix test * golint --------- Co-authored-by: Anton Kaliaev <anton.kalyaev@gmail.com>
…t#1730) (cometbft#1746) * fix: increase abci socket message size limit to 2GB (cometbft#1730) * fix: increase abci socket message size to 2GB * fix: added .changelog * Update .changelog/unreleased/improvements/1730-increase-abci-socket-message-size-limit Co-authored-by: Anton Kaliaev <anton.kalyaev@gmail.com> * fix: use MaxInt32 as message size for 32-bit systems * Update .changelog/unreleased/improvements/1730-increase-abci-socket-message-size-limit --------- Co-authored-by: Anton Kaliaev <anton.kalyaev@gmail.com> Co-authored-by: Thane Thomson <connect@thanethomson.com> (cherry picked from commit 092b918) * Rename 1730-increase-abci-socket-message-size-limit to 1730-increase-abci-socket-message-size-limit.md --------- Co-authored-by: Troy Kessler <43882936+troykessler@users.noreply.github.com> Co-authored-by: Thane Thomson <connect@thanethomson.com>
* fix: The calculation method of tx size returned by calling proxyapp should be consistent with that of mempool * Revert CHANGELOG.md entries should go into .changelog --------- Co-authored-by: lasaro <lasaro@informal.systems> Co-authored-by: lasaro <lasaro@gmail.com> (cherry picked from commit eb5d9ce) Co-authored-by: leven <112051166+lx-xiang@users.noreply.github.com>
* Update CODE_OF_CONDUCT.md Updated the contact email to an `informal.systems` one, and some nits. * Update CODE_OF_CONDUCT.md Co-authored-by: Anton Kaliaev <anton.kalyaev@gmail.com> --------- Co-authored-by: Anton Kaliaev <anton.kalyaev@gmail.com> (cherry picked from commit bde1111) Co-authored-by: Adi Seredinschi <adizere@gmail.com>
…ns (backport cometbft#1756) (cometbft#1774) * [e2e] Fixes prepareProposal not to return oversized set of transactions (cometbft#1756) * Fixes prepareProposal not to return oversized set of transactions * Update test/e2e/app/app.go * Fix linting error * add changelog entry * Avoid marshalling the tx twice * removing unneeded changelog (cherry picked from commit 0bf3f0a) # Conflicts: # test/e2e/app/app.go * Solve conflict --------- Co-authored-by: lasaro <lasaro@informal.systems>
…1760) * Add test missing in cometbft#1687 (cometbft#1712) * Experimenting the fix from lx-xiang * Fixes name in the example * Reverts fix, so it is merged from the proper branch. * Adds a test that fails because the validate is wrong and accepts a block that is larger than it should. * Add changelog for the original PR * Update internal/state/execution_test.go (cherry picked from commit ce0215c) # Conflicts: # abci/example/kvstore/kvstore.go * Reverting change in ABCI type name * Update type of test function * solving conflict in test * Solve conflicts * remove unused variable * Fix mocking function * revert signature change * Apply type cast * Apply type cast --------- Co-authored-by: lasaro <lasaro@informal.systems>
Bumps [actions/setup-go](https://github.com/actions/setup-go) from 4 to 5. - [Release notes](https://github.com/actions/setup-go/releases) - [Commits](actions/setup-go@v4...v5) --- updated-dependencies: - dependency-name: actions/setup-go dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [actions/stale](https://github.com/actions/stale) from 8 to 9. - [Release notes](https://github.com/actions/stale/releases) - [Changelog](https://github.com/actions/stale/blob/main/CHANGELOG.md) - [Commits](actions/stale@v8...v9) --- updated-dependencies: - dependency-name: actions/stale dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
…LightTrusting` (cometbft#1806) * [e2e] Repro evidence bug: not checking all signatures * Introduce `countAllSignatures` in `VerifyCommitLight` & `VerifyCommitLightTrusting` * Revert unneded change * Addressed @insumity's comments --------- Co-authored-by: Jasmina Malicevic <jasmina.dustinac@gmail.com>
(cherry picked from commit 437391a) Co-authored-by: Sergio Mena <sergio@informal.systems>
* use latest golangci-lint-action * make the linter run on workflow changes too * disable 3 linters for now until we fix all the errors * comment out goconst as well * reenable depguard
Otherwise, the events from app's BeginBlock won't be fired. Closes cometbft#1468 Co-authored-by: forcodedancing <just.haha.it@gmail.com>
Bumps [actions/upload-artifact](https://github.com/actions/upload-artifact) from 3 to 4. - [Release notes](https://github.com/actions/upload-artifact/releases) - [Commits](actions/upload-artifact@v3...v4) --- updated-dependencies: - dependency-name: actions/upload-artifact dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
…ft#1864) * Updates go crypto package to v0.17.0 (cometbft#1859) (cherry picked from commit fd87fda) # Conflicts: # go.mod # go.sum * Solving conflict --------- Co-authored-by: lasaro <lasaro@informal.systems>
…cometbft#1871) * Allow blocksync to not verify all signatures (cometbft#1858) * Blocksync can skip sigs * bump (cherry picked from commit 9446e31) # Conflicts: # blocksync/reactor.go * Revert "Allow blocksync to not verify all signatures (cometbft#1858)" This reverts commit 4f2a211. * Allow blocksync to not verify all signatures (cometbft#1858) * Blocksync can skip sigs * bump --------- Co-authored-by: Sergio Mena <sergio@informal.systems>
…1895) * docs: Fix Discord links in README (cometbft#1874) Signed-off-by: Thane Thomson <connect@thanethomson.com> (cherry picked from commit f72d930) # Conflicts: # README.md * fix conflicts --------- Co-authored-by: Thane Thomson <connect@thanethomson.com> Co-authored-by: Anton Kaliaev <anton.kalyaev@gmail.com>
Signed-off-by: Jacob Gadikian <jacobgadikian@gmail.com>
This reverts commit ab4efc4.
This reverts commit 38358da.
…s-for-fixed-length
|
Step one is we need to merge this... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
test/e2e(Rename insidetest/e2ecometbft/cometbft#139) ([backport] Rename insidetest/e2e(#139) cometbft/cometbft#144)v0.37.x(deps: Bump tm-load-test to v1.3.0 onv0.37.xcometbft/cometbft#164)v0.37.xcometbft/cometbft#189)v0.37.xcometbft/cometbft#257)v0.37.x(Upgrade to Go 1.19 onv0.37.xcometbft/cometbft#208)needProofBlockproblem based on themainbranch (Short-term fix forneedProofBlockproblem based on themainbranch cometbft/cometbft#387) (Short-term fix forneedProofBlockproblem based on themainbranch (backport #387) cometbft/cometbft#400)RPCleft navigation cometbft/cometbft#420)block_synckey as deprecated (config: markblock_synckey as deprecated cometbft/cometbft#414)TestStateOversizedBlock(backport FixTestStateOversizedBlockcometbft/cometbft#755) (FixTestStateOversizedBlock(backport #755) cometbft/cometbft#765)Clientexposes sensitive data (StructClientexposes sensitive data cometbft/cometbft#784) (StructClientexposes sensitive data (backport #784) cometbft/cometbft#787)killcommand (backport Unsafe int cast inkillcommand cometbft/cometbft#783) (Unsafe int cast inkillcommand (backport #783) cometbft/cometbft#793)CheckTxin ABCI spec (backport Add requirement forCheckTxin ABCI spec cometbft/cometbft#928) (Add requirement forCheckTxin ABCI spec (backport #928) cometbft/cometbft#965)CMT_HOME(or remove it?) (backport AddCMT_HOME(or remove it?) cometbft/cometbft#983) (AddCMT_HOME(or remove it?) (backport #983) cometbft/cometbft#999)nopmempool (backport mempool: addnopmempool cometbft/cometbft#1643) (mempool: addnopmempool (backport #1643) cometbft/cometbft#1681)countAllSignaturesinVerifyCommitLight&VerifyCommitLightTrusting(IntroducecountAllSignaturesinVerifyCommitLight&VerifyCommitLightTrustingcometbft/cometbft#1806)PR checklist
.changelog(we use unclog to manage our changelog)docs/orspec/) and code comments