cmd: Remove snake case deprecation warning

[thanethomson]

While working on #625 I discovered this. We have aliases for both types of commands, so I don't think there's any need to issue a warning here.

---

PR checklist

• Tests written/updated
• Changelog entry added in .changelog (we use unclog to manage our changelog)
• Updated relevant documentation (docs/ or spec/) and code comments

[sergio-mena]

The changes make sense technically. However, I have the impression that they added the "deprecate snake case warning" because they were planning to remove the (snake_case) aliases in a subsequent breaking release.
(take a look at this and this)

[thanethomson]

Do we still want to remove the snake_case aliases then? Or shouldn't we just offer both? (kebab-case is easier to type when using the CLI)

And wasn't the snake_case deprecation part of the broader effort to kebab-case the config file?

[sergio-mena]

Do we still want to remove the snake_case aliases then? Or shouldn't we just offer both? (kebab-case is easier to type when using the CLI)

I think that deserves a (maybe short) synchronous discussion? I've added a point for tomorrow's internal meeting. I apologize for adding a point to a meeting I'll probably not be able to attend :-|
But I am OK with whatever you folks decide.

And wasn't the snake_case deprecation part of the broader effort to kebab-case the config file?

I think so, although, by the age of tendermint/tendermint#5786 and tendermint/tendermint#5777, I'd say they first tackled this, and later (as of v0.35.x) they tackled the config.toml.

[thanethomson]

I think that deserves a (maybe short) synchronous discussion?

We spoke about it in the team call today and we decided to:

1. Continue to offer kebab-case CLI commands as the default, as it's generally more ergonomic to type than snake_case when using the CLI.
2. Continue to provide snake_case CLI aliases to not break folks who depend on them.
3. Remove the deprecation warning.