Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for outputting bundles with JSX extensions #76

Closed
XiNiHa opened this issue Dec 14, 2022 · 1 comment · Fixed by #73
Closed

Support for outputting bundles with JSX extensions #76

XiNiHa opened this issue Dec 14, 2022 · 1 comment · Fixed by #73
Labels
enhancement New feature or request

Comments

@XiNiHa
Copy link

XiNiHa commented Dec 14, 2022

While Nanobundle respects "jsx": "preserve" in TSConfig and emits it as-is, I found that it doesn't accept JSX family extensions (.jsx, .mjsx, .cjsx) as output file extensions (instead it tries to look for something like index.mjsx.js, ...)
Outputting files with JSX extensions is important because Vite doesn't accept JSX when the extension is just plain .js. Transpiling the JSX when bundling isn't an option that I can consider. (since I'm currently building a library that exports a component for SolidJS)
Would it be possible to support outputting files with JSX extensions?

@cometkim cometkim added the bug Something isn't working label Dec 14, 2022
@cometkim cometkim changed the title Support for outputting files with JSX extensions Support for outputting bundles with JSX extensions Dec 14, 2022
@cometkim cometkim added enhancement New feature or request and removed bug Something isn't working labels Dec 14, 2022
@cometkim
Copy link
Owner

This will be allowed in v1.1.0, but generally not recommended

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants