Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add TLS/SSL Support #1481

Closed
wants to merge 2 commits into from
Closed

Conversation

ElliottLester
Copy link

@ElliottLester ElliottLester commented Sep 10, 2023

Add --tls-keyfile and --tls-certfile options
If both are provided:

  • Pass SSLContext to TCPSite
  • Update address scheme to https for the prompt and auto_launch

Thank you for maintaining this project, It's awesome.

Add --tls-keyfile and --tls-certfile options
If both are provided:
- Pass SSLContext to TCPSite
- Update address scheme to https for the prompt and auto_launch
@mcmonkey4eva
Copy link
Collaborator

You, uh, probably shouldn't be hosting ComfyUI on a public domain in the first place?

@ElliottLester
Copy link
Author

ElliottLester commented Sep 16, 2023

You, uh, probably shouldn't be hosting ComfyUI on a public domain in the first place?

It's internal self signed I just don't want people implementing other encryption schemes when they should just be using TLS.
Automatic1111 stable diffusion webui does the same thing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants