Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add TLS Support #3312

Merged
merged 6 commits into from
May 1, 2024
Merged

Add TLS Support #3312

merged 6 commits into from
May 1, 2024

Conversation

garrettsutula
Copy link
Contributor

  • Add two cli arguments to allow key and cert file path to be passed to enable TLS, make the app accessible athttps://...
  • Update readme, add example of how to use.

Ref #1481 #1105

@comfyanonymous
Copy link
Owner

Does this work on windows?

@garrettsutula
Copy link
Contributor Author

@comfyanonymous it sure does! I just added a note to the README with a couple options for generating certificates with openssl as a Windows user.

@comfyanonymous comfyanonymous merged commit bacce52 into comfyanonymous:master May 1, 2024
1 check passed
Lin1031 pushed a commit to Lin1031/ComfyUI that referenced this pull request May 14, 2024
@garrettsutula
Add TLS Support (comfyanonymous#3312)
0e0bd89 
* Add TLS Support

* Add to readme

* Add guidance for windows users on generating certificates

* Add guidance for windows users on generating certificates

* Fix typo
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@comfyanonymous comfyanonymous Awaiting requested review from comfyanonymous comfyanonymous is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@garrettsutula @comfyanonymous