Add Features "Load prompt from layer" #23
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
ElliottLester
commented
Sep 12, 2023
ElliottLester
commented
- Add Prompt response class
- More robust failure handling
- Remove all base64 from response path
- Add SSL/HTTPS support for use with Add TLS/SSL Support comfyanonymous/ComfyUI#1481
Scope: We want to restore the state of SDImgPageBase from an already generated layer. To do this we create a class to store a response and all it's parts that can be converted to json Changes: - Create prompt.py - Formalize craft response dataclass - Create class that can be serialized - looking at tests, but we need to import PyQt5 parts directly not through krita. - allow for text in front of the json - from_history_json() - Add prompt_from_selection - Remove all base64 from the response path - All responses are now PromptResponse - Assert images doesn't exceed names
for debugging
We should check if the response has images in it before we try to insert them. Then notify the user the Server sent us an empty response. Added: ERR_BACKEND ERR_EMPTY_RESPONSE
JasonS09
requested changes
Sep 12, 2023
JasonS09
approved these changes
Sep 12, 2023
|
Thanks for your contribution, it's very useful! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.