Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Support for SD3 ControlNet #3734

Closed
Fannovel16 opened this issue Jun 15, 2024 · 10 comments
Closed

[Feature] Support for SD3 ControlNet #3734

Fannovel16 opened this issue Jun 15, 2024 · 10 comments
Labels
Feature A new feature to add to ComfyUI.

Comments

@Fannovel16
Copy link
Contributor

Fannovel16 commented Jun 15, 2024

Chads from InstantX (who created InstantID) has made several ControlNet for SD3-Medium, including:

Their implementation can be found at huggingface/diffusers#8566

@kadirnar
Copy link
Contributor

+1

@mcmonkey4eva mcmonkey4eva added the Feature A new feature to add to ComfyUI. label Jun 15, 2024
@sanjay-uzu
Copy link

But these models are not working in comfyui

@Fannovel16
Copy link
Contributor Author

@sanjay-uzu That is why we need an issue

@zsxkib
Copy link

zsxkib commented Jun 18, 2024

"Chads from InstantX" lol @Fannovel16

@geroldmeisinger
Copy link

controlnet support merged into diffusers
huggingface/diffusers#8566 (comment)

@geroldmeisinger
Copy link

geroldmeisinger commented Jun 20, 2024

state of the model seems subpar atm https://huggingface.co/InstantX/SD3-Controlnet-Canny/discussions/4
but I guess a 1.0 version will follow soon
anyone had better results yet?

@kijai
Copy link
Contributor

kijai commented Jun 24, 2024

state of the model seems subpar atm https://huggingface.co/InstantX/SD3-Controlnet-Canny/discussions/4 but I guess a 1.0 version will follow soon anyone had better results yet?

Here's some of my tests, post and tile work pretty good. This is using diffusers with a wrapper node I made to test this, I added some of the standard CN features that was missing (start/end, guess_mode). Canny seems to work better with more defined input, I found using lineart preproc better. I do definitely think it's worth implementing!

sd3_canny_lines
sd3_pose_02
sd3_tilecn
sd3_pose_gorilla
sd3_pose_cn

sd3_pose_tile_cn_02

@al-swaiti
Copy link

its here but in diffusers mode
https://github.com/ZHO-ZHO-ZHO/ComfyUI-SD3-Medium-CN-Diffusers
waiting for normal one

@mcmonkey4eva
Copy link
Contributor

Added to Comfy yesterday 264caca use ControlNetApplySD3 node

@geroldmeisinger
Copy link

@kijai can you please try it again with something non-human and non-architectural, like an animal. the controlnet seems to have an effect and working but i'm not getting any good results with the dog2.png test image of the original controlnet :/

dog2 square-cropped and upscaled to 1024x1024:
dog2upscale

dog2canny

dog2result

I trained canny controlnets on my own and this result looks to me as if a) the CN didn't yet fully converge or b) the model collapsed at some point.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature A new feature to add to ComfyUI.
Projects
None yet
Development

No branches or pull requests

8 participants